Should not set transfer-encoding header for 204 response according to http specs

Author: tommysitu

examples/go.mod

@@ -1,8 +1,15 @@
 module github.com/elazarl/goproxy/examples/goproxy-transparent
 
+go 1.22.5
+
 require (
 	github.com/elazarl/goproxy v0.0.0-20181111060418-2ce16c963a8a
 	github.com/inconshreveable/go-vhost v0.0.0-20160627193104-06d84117953b
 )
 
+require (
+	github.com/SpectoLabs/goproxy/ext v0.0.0-20220724222243-c982a2c966ae // indirect
+	github.com/rogpeppe/go-charset v0.0.0-20180617210344-2471d30d28b4 // indirect
+)
+
 replace github.com/elazarl/goproxy => ../

examples/go.sum

@@ -1,3 +1,4 @@
+github.com/SpectoLabs/goproxy/ext v0.0.0-20220724222243-c982a2c966ae/go.mod h1:rnDN1CpKP9iJXwxRtnvM7d5wdPHQY0K5NkHeXWPlQ+o=
 github.com/elazarl/goproxy/ext v0.0.0-20190711103511-473e67f1d7d2/go.mod h1:gNh8nYJoAm43RfaxurUnxr+N1PwuFV3ZMl/efxlIlY8=
 github.com/inconshreveable/go-vhost v0.0.0-20160627193104-06d84117953b h1:IpLPmn6Re21F0MaV6Zsc5RdSE6KuoFpWmHiUSEs3PrE=
 github.com/inconshreveable/go-vhost v0.0.0-20160627193104-06d84117953b/go.mod h1:aA6DnFhALT3zH0y+A39we+zbrdMC2N0X/q21e6FI0LU=

https.go

@@ -267,7 +267,7 @@ func (proxy *ProxyHttpServer) handleHttps(w http.ResponseWriter, r *http.Request
 					return
 				}
 
-				if resp.Request.Method == "HEAD" {
+				if resp.Request.Method == "HEAD" || resp.StatusCode == 204 {
 					// don't change Content-Length for HEAD request
 				} else {
 					// Since we don't know the length of resp, return chunked encoded response
@@ -286,7 +286,7 @@ func (proxy *ProxyHttpServer) handleHttps(w http.ResponseWriter, r *http.Request
 					return
 				}
 
-				if resp.Request.Method == "HEAD" {
+				if resp.Request.Method == "HEAD" || resp.StatusCode == 204 {
 					// Don't write out a response body for HEAD request
 				} else {
 					chunked := newChunkedWriter(rawClientTls)