Merge pull request #8 from JetBrains-Research/vector-python

Vector for python-package

Author: EgorOrachyov

README.md

@@ -18,15 +18,15 @@ The library provides C-compatible API, written in the GraphBLAS style.
 cuBool library C API. This package exports library features and primitives 
 in high-level format with automated resources management and fancy syntax sugar.
 
-**The primary library primitive** is a sparse boolean matrix. The library provides 
-the most popular operations for matrix manipulation, such as construction from
-values, transpose, sub-matrix extraction, matrix-to-vector reduce, matrix-matrix
-element-wise addition, matrix-matrix multiplication and Kronecker product.  
+**The primary library primitives** are sparse matrix and sparse vector of boolean values. 
+The library provides the most popular operations for matrix manipulation, 
+such as construction from values, transpose, sub-matrix/sub-vector extraction, matrix-to-vector reduce, 
+element-wise addition, matrix-matrix, matrix-vector, vector-matrix multiplication, and Kronecker product.  
 
 **As a fallback** library provides sequential backend for mentioned above operations
 for computations on CPU side only. This backend is selected automatically
 if Cuda compatible device is not presented in the system. This can be quite handy for 
-prototyping algorithms on a local computer for later running on a powerful server.  
+prototyping algorithms on a local computer for later running on a powerful server.   
 
 **PyPI package web page** is following [link](https://pypi.org/project/pycubool/).
 
@@ -36,20 +36,23 @@ prototyping algorithms on a local computer for later running on a powerful serve
 - Python package for every-day tasks
 - Cuda backend for computations
 - Cpu backend for computations
-- Matrix creation (empty, from data, with random data)
+- Matrix/vector creation (empty, from data, with random data)
 - Matrix-matrix operations (multiplication, element-wise addition, kronecker product)
+- Matrix-vector operations (matrix-vector and vector-matrix multiplication)
+- Vector-vector operations (element-wise addition)
 - Matrix operations (equality, transpose, reduce to vector, extract sub-matrix)
-- Matrix data extraction (as lists, as list of pairs)
-- Matrix syntax sugar (pretty string printing, slicing, iterating through non-zero values)
+- Vector operations (equality, reduce to value, extract sub-vector)
+- Matrix/vector data extraction (as lists, as list of pairs)
+- Matrix/vector syntax sugar (pretty string printing, slicing, iterating through non-zero values)
 - IO (import/export matrix from/to `.mtx` file format)
 - GraphViz (export single matrix or set of matrices as a graph with custom color and label settings)
-- Debug (matrix string debug markers, logging)
+- Debug (matrix string debug markers, logging) 
 
 ### Platforms
 
 - Linux based OS (tested on Ubuntu 20.04)
-- Windows (coming soon)
-- macOS (coming soon)
+- Windows (not tested yet)
+- macOS (not tested yet)
 
 ### Simple example
 

cubool/sources/core/matrix.cpp

@@ -40,11 +40,6 @@ namespace cubool {
     Matrix::Matrix(size_t nrows, size_t ncols, BackendBase &backend) {
         mHnd = backend.createMatrix(nrows, ncols);
         mProvider = &backend;
-
-        // By default marker is the address of the matrix
-        std::stringstream s;
-        s << this;
-        mMarker = s.str();
     }
 
     Matrix::~Matrix() {

cubool/sources/core/object.cpp

@@ -27,6 +27,13 @@
 
 namespace cubool {
 
+    Object::Object() {
+        // By default marker is the address of the object
+        std::stringstream s;
+        s << this;
+        mMarker = s.str();
+    }
+
     void Object::setDebugMarker(const char *marker) {
         CHECK_RAISE_ERROR(marker, InvalidArgument, "Null pointer marker string");
 

cubool/sources/core/object.hpp

@@ -32,6 +32,7 @@ namespace cubool {
 
     class Object {
     public:
+        Object();
         void setDebugMarker(const char* marker);
         const char* getDebugMarker() const;
         index getDebugMarkerSizeWithNullT() const;

cubool/sources/core/vector.cpp

@@ -40,11 +40,6 @@ namespace cubool {
     Vector::Vector(size_t nrows, BackendBase &backend) {
         mHnd = backend.createVector(nrows);
         mProvider = &backend;
-
-        // By default marker is the address of the vector
-        std::stringstream s;
-        s << this;
-        mMarker = s.str();
     }
 
     Vector::~Vector() {

cubool/sources/core/vector.hpp

@@ -65,9 +65,6 @@ namespace cubool {
         // Cached values by the set functions
         mutable std::vector<index> mCachedI;
 
-        // Marker for debugging
-        std::string mMarker;
-
         // Implementation handle references
         VectorBase* mHnd = nullptr;
         BackendBase* mProvider = nullptr;

cubool/sources/cuda/cuda_vector.cu

@@ -124,8 +124,8 @@ namespace cubool {
         index firstToCopy = region.front();
 
         VectorImplType::container_type result(resultSize);
-        thrust::copy(vec.m_rows_index.begin() + firstToCopy, vec.m_rows_index.begin() + firstToCopy + resultSize,
-                     result.begin());
+        thrust::transform(vec.m_rows_index.begin() + firstToCopy, vec.m_rows_index.begin() + firstToCopy + resultSize,result.begin(),
+                          [i]__device__(index id) { return id - i; });
 
         // Update this impl data
         mVectorImpl = std::move(VectorImplType(std::move(result), nrows, resultSize));

cubool/sources/cuda/kernels/spreduce.cuh

@@ -143,7 +143,6 @@ namespace cubool {
             using VectorType = details::SpVector<IndexType, AllocType>;
 
             VectorType operator()(const MatrixType& m) {
-                auto nrows = m.m_rows;
                 auto ncols = m.m_cols;
                 auto nvals = m.m_vals;
 
@@ -156,33 +155,34 @@ namespace cubool {
                          __device__ (IndexType i) {
                          auto j = colIndex[i];
 
-                         atomicOr((mask + j).get(), (IndexType) 1);
+                         mask[j] = 0x1u;
                      }
                 );
 
                 // Count nnz of the vector
                 auto resultSize = thrust::reduce(mask.begin(), mask.end(), (IndexType) 0);
 
                 ContainerType<index> result(resultSize);
-                ContainerType<index> offsets(mask.size());
-
-                // Evaluate write offsets of the result
-                thrust::exclusive_scan(mask.begin(), mask.end(), offsets.begin(), (IndexType) 0, thrust::plus<IndexType>());
+                ContainerType<index> order(1);
+                thrust::fill(order.begin(), order.end(), (IndexType) 0);
 
                 // For each value of the mask write in the result buffer if it not zero
                 thrust::for_each(thrust::counting_iterator<IndexType>(0), thrust::counting_iterator<IndexType>(ncols),
-                     [mask = mask.data(), result = result.data(), offsets = offsets.data()]
+                     [mask = mask.data(), result = result.data(), order = order.data()]
                          __device__ (IndexType i) {
                         if (mask[i] > 0) {
-                            auto offset = offsets[i];
+                            auto offset = atomicAdd(order.get(), (IndexType) 1);
                             auto colId = i;
 
                             result[offset] = colId;
                         }
                      }
                 );
 
-                return VectorType(std::move(result), nrows, resultSize);
+                // Sort values within vector
+                thrust::sort(result.begin(), result.end());
+
+                return VectorType(std::move(result), ncols, resultSize);
             }
 
         };

cubool/sources/sequential/sq_subvector.cpp

@@ -48,7 +48,7 @@ namespace cubool {
 
         for (auto v: a.indices) {
             if (first <= v && v < last) {
-                out.indices.push_back(v);
+                out.indices.push_back(v - i);
             }
         }
     }

cubool/tests/test_library_api.cpp

@@ -76,7 +76,7 @@ cuBool_Status TransitiveClosure(cuBool_Matrix A, cuBool_Matrix* T) {
     return CUBOOL_STATUS_SUCCESS;
 }
 
-TEST(cuBool, Example) {
+TEST(cuBool, TsExample) {
     cuBool_Matrix A = nullptr;
     cuBool_Matrix T = nullptr;