refactor(document): improve id validation logic

Spamercz · Spamercz · commit 5bcdc83779db · 2026-02-13T16:25:04.000+01:00
- Updated id check to ensure it is a non-empty string
- Simplified conditional structure for clarity
diff --git a/src/Document.php b/src/Document.php
@@ -30,7 +30,10 @@ public function toArray(): array
 			$array['body'] = $this->body->toArray();
 		}
 
-		if ($this->id instanceof \Spameri\Elastic\Entity\Property\ElasticId) {
+		if (
+			\is_string($this->id)
+			&& $this->id !== ''
+		) {
 			$array['id'] = $this->id;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,10 @@ public function toArray(): array`
`30`	`30`	`$array['body'] = $this->body->toArray();`
`31`	`31`	`}`
`32`	`32`
`33`		`- if ($this->id instanceof \Spameri\Elastic\Entity\Property\ElasticId) {`
	`33`	`+ if (`
	`34`	`+ \is_string($this->id)`
	`35`	`+ && $this->id !== ''`
	`36`	`+ ) {`
`34`	`37`	`$array['id'] = $this->id;`
`35`	`38`	`}`
`36`	`39`