Skip to content

Commit f159eac

Browse files
committed
cleanup
1 parent 076d368 commit f159eac

File tree

3 files changed

+31
-1
lines changed

3 files changed

+31
-1
lines changed

kafka-webview-ui/src/main/java/org/sourcelab/kafka/webview/ui/controller/configuration/cluster/ClusterConfigController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ public String getClientConfig(
560560
kafkaOperationsFactory.getConsumerConfig(cluster, getLoggedInUserId()),
561561
cluster
562562
)
563-
// Sort by key
563+
// Sort by key for easier display.
564564
.entrySet().stream()
565565
.sorted(Map.Entry.comparingByKey())
566566
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue, (oldValue, newValue) -> oldValue, LinkedHashMap::new));

kafka-webview-ui/src/main/java/org/sourcelab/kafka/webview/ui/controller/configuration/cluster/forms/ClusterForm.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,13 +319,19 @@ public void setCustomOptionValues(final List<String> customOptionValues) {
319319
this.customOptionValues = customOptionValues;
320320
}
321321

322+
/**
323+
* Enable/Disable flag for custom client options.
324+
*/
322325
public Boolean getCustomOptionsEnabled() {
323326
if (customOptionsEnabled == null) {
324327
return customOptionsEnabled = false;
325328
}
326329
return customOptionsEnabled;
327330
}
328331

332+
/**
333+
* Enable/Disable flag for custom client options.
334+
*/
329335
public void setCustomOptionsEnabled(final Boolean customOptionsEnabled) {
330336
if (customOptionsEnabled == null) {
331337
this.customOptionsEnabled = false;

kafka-webview-ui/src/test/java/org/sourcelab/kafka/webview/ui/manager/SensitiveConfigScrubberTest.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,27 @@
1+
/**
2+
* MIT License
3+
*
4+
* Copyright (c) 2017, 2018, 2019 SourceLab.org (https://github.com/SourceLabOrg/kafka-webview/)
5+
*
6+
* Permission is hereby granted, free of charge, to any person obtaining a copy
7+
* of this software and associated documentation files (the "Software"), to deal
8+
* in the Software without restriction, including without limitation the rights
9+
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10+
* copies of the Software, and to permit persons to whom the Software is
11+
* furnished to do so, subject to the following conditions:
12+
*
13+
* The above copyright notice and this permission notice shall be included in all
14+
* copies or substantial portions of the Software.
15+
*
16+
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17+
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18+
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19+
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20+
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21+
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22+
* SOFTWARE.
23+
*/
24+
125
package org.sourcelab.kafka.webview.ui.manager;
226

327
import org.apache.kafka.common.config.SaslConfigs;

0 commit comments

Comments
 (0)