Skip to content

Commit bad824b

Browse files
committed
resolve bug
1 parent 30fbe3e commit bad824b

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
The format is based on [Keep a Changelog](http://keepachangelog.com/)
33
and this project adheres to [Semantic Versioning](http://semver.org/).
44

5+
## 0.2.1 Bugfix Release
6+
- Request interceptors could be bypassed for some GET requests.
7+
58
## 0.2.0 Bugfix Release
69
- Use appropriate SLF4J log interface, remove explicit logging dependencies.
710

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>org.sourcelab.http</groupId>
88
<artifactId>http-client-wrapper</artifactId>
9-
<version>0.2.0</version>
9+
<version>0.2.1</version>
1010
<packaging>jar</packaging>
1111

1212
<!-- Require Maven 3.3.9 -->

src/main/java/org/sourcelab/http/rest/HttpClientRestClient.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -279,16 +279,18 @@ private <T> T submitGetRequest(
279279
final URIBuilder uriBuilder = new URIBuilder(url)
280280
.setCharset(StandardCharsets.UTF_8);
281281

282+
// Process request parameters/
283+
List<RequestParameter> requestParameters = new ArrayList<>();
282284
if (requestBodyContent instanceof UrlEncodedFormBodyContent) {
283-
final List<RequestParameter> requestParameters = processRequestParameters(
284-
((UrlEncodedFormBodyContent) requestBodyContent).getRequestParameters(),
285-
requestContext
286-
);
285+
requestParameters = ((UrlEncodedFormBodyContent) requestBodyContent).getRequestParameters();
286+
}
287287

288-
// Attach submitRequest params
289-
for (final RequestParameter requestParameter : requestParameters) {
290-
uriBuilder.setParameter(requestParameter.getName(), requestParameter.getValue());
291-
}
288+
// run parameters through interceptors.
289+
requestParameters = processRequestParameters(requestParameters, requestContext);
290+
291+
// Attach submitRequest params
292+
for (final RequestParameter requestParameter : requestParameters) {
293+
uriBuilder.setParameter(requestParameter.getName(), requestParameter.getValue());
292294
}
293295

294296
// Build Get Request

0 commit comments

Comments
 (0)