From acfdd4191dfd471fd2e9f36ffe01c21a2e512e7d Mon Sep 17 00:00:00 2001 From: kentarohorie Date: Thu, 19 Nov 2020 21:02:03 +0900 Subject: [PATCH 1/2] Change variable name in add_provider_to_user: user => authentication --- lib/sorcery/model/submodules/external.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/sorcery/model/submodules/external.rb b/lib/sorcery/model/submodules/external.rb index 7c33d8a0..a885cbb1 100644 --- a/lib/sorcery/model/submodules/external.rb +++ b/lib/sorcery/model/submodules/external.rb @@ -96,14 +96,14 @@ def add_provider_to_user(provider, uid) authentications = sorcery_config.authentications_class.name.demodulize.underscore.pluralize # first check to see if user has a particular authentication already if sorcery_adapter.find_authentication_by_oauth_credentials(authentications, provider, uid).nil? - user = send(authentications).build(sorcery_config.provider_uid_attribute_name => uid, + authentication = send(authentications).build(sorcery_config.provider_uid_attribute_name => uid, sorcery_config.provider_attribute_name => provider) - user.sorcery_adapter.save(validate: false) + authentication.sorcery_adapter.save(validate: false) else - user = false + authentication = false end - user + authentication end end end From d51fe7ba3ef98fbfbd48c32288e894d4aae4be7b Mon Sep 17 00:00:00 2001 From: kentarohorie Date: Thu, 19 Nov 2020 21:04:05 +0900 Subject: [PATCH 2/2] Make returning simple about add_provider_to_user --- lib/sorcery/model/submodules/external.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/sorcery/model/submodules/external.rb b/lib/sorcery/model/submodules/external.rb index a885cbb1..dcf23e84 100644 --- a/lib/sorcery/model/submodules/external.rb +++ b/lib/sorcery/model/submodules/external.rb @@ -100,10 +100,8 @@ def add_provider_to_user(provider, uid) sorcery_config.provider_attribute_name => provider) authentication.sorcery_adapter.save(validate: false) else - authentication = false + false end - - authentication end end end