Fix RSpec/Yield cop violations

willnet · willnet · commit c9eed48691f8 · 2025-12-02T15:47:10.000+09:00
diff --git a/spec/controllers/controller_spec.rb b/spec/controllers/controller_spec.rb
@@ -90,7 +90,7 @@
     describe '#login!' do
       context 'when succeeds' do
         before do
-          expect(User).to receive(:authenticate).with('bla@example.com', 'secret') { |&block| block.call(user, nil) }
+          expect(User).to receive(:authenticate).with('bla@example.com', 'secret').and_yield(user, nil)
           get :test_login_bang, params: { email: 'bla@example.com', password: 'secret' }
         end
 
@@ -119,7 +119,7 @@
     describe '#login! with block' do
       context 'when succeeds' do
         before do
-          expect(User).to receive(:authenticate).with('bla@example.com', 'secret') { |&block| block.call(user, nil) }
+          expect(User).to receive(:authenticate).with('bla@example.com', 'secret').and_yield(user, nil)
           get :test_login_bang_with_block, params: { email: 'bla@example.com', password: 'secret' }
         end
 

-Original file line number
+Diff line change
     describe '#login!' do
       context 'when succeeds' do
         before do
 -          expect(User).to receive(:authenticate).with('[email protected]', 'secret') { |&block| block.call(user, nil) }
 +          expect(User).to receive(:authenticate).with('[email protected]', 'secret').and_yield(user, nil)
           get :test_login_bang, params: { email: '[email protected]', password: 'secret' }
         end
     describe '#login! with block' do
       context 'when succeeds' do
         before do
 -          expect(User).to receive(:authenticate).with('[email protected]', 'secret') { |&block| block.call(user, nil) }
 +          expect(User).to receive(:authenticate).with('[email protected]', 'secret').and_yield(user, nil)
           get :test_login_bang_with_block, params: { email: '[email protected]', password: 'secret' }
         end