Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add letter search minigame #55

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

add letter search minigame #55

wants to merge 7 commits into from

Conversation

kguzek
Copy link
Member

@kguzek kguzek commented Dec 22, 2024 •
edited
Loading

Zmiany:

  • automatyczne ustalanie obecnego hasła
  • automatyczne wybieranie zakładki do wyświetlania literki na podstawie UUID wpisu
  • wyświetlanie odpowiedniej literki w losowym miejscu na podanej stronie
  • przechowywanie znalezionych literek w cookies
  • komunikat od ShadCN na kliknięciu literki

@Copilot Copilot bot review requested due to automatic review settings December 22, 2024 12:19
@kguzek kguzek linked an issue Dec 22, 2024 that may be closed by this pull request
feat/ game demo #6
Open
@kguzek kguzek requested review from Octopus4344 and Rei-x and removed request for Copilot December 22, 2024 12:19
@kguzek kguzek added the enhancement New feature or request label Dec 22, 2024
@solvro-coolify
Copy link

solvro-coolify bot commented Dec 22, 2024 •
edited
Loading

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-12-29 00:56:13 CET

Octopus4344
Octopus4344 requested changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@Octopus4344 Octopus4344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegancko generalnie, kodzik bardzo fajny, nie jestem przekonana co do algorytmu wyliczania miejsca renderowania, moim zdaniem wprowadzmy losowosc

src/components/phrase-search/letter.tsx Show resolved Hide resolved
src/components/phrase-search/letter.tsx Outdated Show resolved Hide resolved
src/components/phrase-search/letter.tsx Show resolved Hide resolved
@kguzek kguzek force-pushed the feat/letter-search-minigame branch from 1d238cd to 2c05d47 Compare January 2, 2025 20:15
@kguzek kguzek requested a review from Octopus4344 January 2, 2025 20:17
@kguzek kguzek enabled auto-merge (rebase) January 2, 2025 20:19
Octopus4344
Octopus4344 requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@Octopus4344 Octopus4344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nie uwzględniłeś prawidłowo granic strony i przez to literki się genrują w zupełnie przypadkowych miejscach i np, trzeba do nich spory kawal drogi scrollowac.

@kguzek
Copy link
Member Author

kguzek commented Jan 7, 2025

Nie uwzględniłeś prawidłowo granic strony i przez to literki się genrują w zupełnie przypadkowych miejscach i np, trzeba do nich spory kawal drogi scrollowac.

Czyli mają być zawsze widoczne na pierwsze wejście, bez potrzeby scrollowania?

@Octopus4344
Copy link
Collaborator

Czy to jest już gotowe do review?

@kguzek
Copy link
Member Author

kguzek commented Jan 19, 2025

Czy to jest już gotowe do review?

tak

@kguzek kguzek force-pushed the feat/letter-search-minigame branch 2 times, most recently from 8c0661a to 8797f7f Compare January 19, 2025 14:57
@kguzek kguzek self-assigned this Jan 19, 2025
@kguzek kguzek requested a review from Octopus4344 January 19, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rei-x Rei-x Awaiting requested review from Rei-x

@Octopus4344 Octopus4344 Awaiting requested review from Octopus4344

Requested changes must be addressed to merge this pull request.

Assignees

@kguzek kguzek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat/ game demo
2 participants
@kguzek @Octopus4344