Skip to content

Reduce unsafe surface and duplicate wrappers in solverforge-cvrp #10

Description

@blackopsrepl

Summary

solverforge-cvrp currently combines repeated unsafe dereferences with duplicate thin wrapper APIs.

Problem

The crate relies on *const ProblemData-style access patterns and exposes overlapping helpers such as assign_route and set_route.

Why This Matters

This raises maintenance cost and safety risk in a public helper API and makes the surface harder to reason about.

Proposed Work

  • Consolidate duplicate route helpers.
  • Strengthen documentation for safety invariants.
  • Investigate safer ownership/reference patterns where feasible.
  • Re-evaluate what should be publicly re-exported from the facade crate.

Acceptance Criteria

  • Duplicate wrapper surface is reduced.
  • Safety invariants are explicit and tested.
  • The public API is easier to reason about.

Source

Derived from PR #3 (PRODUCTION_REVIEW_ISSUES_2026-03-20.md).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions