Cleanup eslint.config.js

Author: jdalton

eslint.config.js

@@ -10,7 +10,7 @@ const sortDestructureKeysPlugin = require('eslint-plugin-sort-destructure-keys')
 const unicornPlugin = require('eslint-plugin-unicorn')
 
 const constants = require('@socketsecurity/registry/lib/constants')
-const { GIT_IGNORE, PRETTIER_IGNORE } = constants
+const { GIT_IGNORE, LATEST, PRETTIER_IGNORE } = constants
 
 const rootPath = __dirname
 
@@ -25,9 +25,12 @@ module.exports = [
     ...importXPlugin.flatConfigs.recommended,
     languageOptions: {
       ...importXPlugin.flatConfigs.recommended.languageOptions,
-      ecmaVersion: 'latest',
+      ecmaVersion: LATEST,
       sourceType: 'script'
     },
+    linterOptions: {
+      reportUnusedDisableDirectives: 'off'
+    },
     rules: {
       ...importXPlugin.flatConfigs.recommended.rules,
       'import-x/no-named-as-default-member': 'off',
@@ -58,17 +61,10 @@ module.exports = [
     }
   },
   {
-    files: ['scripts/**/*.js', 'test/**/*.cjs'],
-    ...nodePlugin.configs['flat/recommended-script']
-  },
-  {
-    files: ['scripts/**/*.js', 'test/**/*.cjs'],
-    plugins: {
-      'sort-destructure-keys': sortDestructureKeysPlugin,
-      unicorn: unicornPlugin
-    },
+    files: ['scripts/**/*.{c,}js', 'test/**/*.{c,}js'],
+    ...nodePlugin.configs['flat/recommended-script'],
     rules: {
-      ...js.configs.recommended.rules,
+      ...nodePlugin.configs['flat/recommended-script'].rules,
       'n/exports-style': ['error', 'module.exports'],
       // The n/no-unpublished-bin rule does does not support non-trivial glob
       // patterns used in package.json "files" fields. In those cases we simplify
@@ -84,7 +80,17 @@ module.exports = [
           version: constants.maintainedNodeVersions.previous
         }
       ],
-      'n/prefer-node-protocol': ['error'],
+      'n/prefer-node-protocol': ['error']
+    }
+  },
+  {
+    files: ['scripts/**/*.{c,}js', 'test/**/*.{c,}js'],
+    plugins: {
+      'sort-destructure-keys': sortDestructureKeysPlugin,
+      unicorn: unicornPlugin
+    },
+    rules: {
+      ...js.configs.recommended.rules,
       'no-await-in-loop': ['error'],
       'no-control-regex': ['error'],
       'no-empty': ['error', { allowEmptyCatch: true }],

test/package-url.test.js

@@ -101,19 +101,22 @@ describe('PackageURL', () => {
     }
 
     it('should validate required params', () => {
-      const testValid = paramName => {
+      // eslint-disable-next-line unicorn/consistent-function-scoping
+      function testValid(paramName) {
         const paramIndex = paramMap[paramName]
         const args = createArgs(paramName, paramName)
         const message = JSON.stringify(args[paramIndex])
         try {
+          // eslint-disable-next-line no-new
           new PackageURL(...args)
           assert.ok(true, message)
         } catch {
           assert.ok(false, message)
         }
       }
 
-      const testInvalid = paramName => {
+      // eslint-disable-next-line unicorn/consistent-function-scoping
+      function testInvalid(paramName) {
         const paramIndex = paramMap[paramName]
         ;[
           createArgs(paramName, 0),
@@ -127,6 +130,7 @@ describe('PackageURL', () => {
         ].forEach(args => {
           const message = JSON.stringify(args[paramIndex])
           try {
+            // eslint-disable-next-line no-new
             new PackageURL(...args)
             assert.ok(false, message)
           } catch {
@@ -135,14 +139,15 @@ describe('PackageURL', () => {
         })
       }
 
-      ;['type', 'name'].forEach(paramName => {
+      for (const paramName of ['type', 'name']) {
         testValid(paramName)
         testInvalid(paramName)
-      })
+      }
     })
 
     it('should validate string params', () => {
-      const testValid = paramName => {
+      // eslint-disable-next-line unicorn/consistent-function-scoping
+      function testValid(paramName) {
         const paramIndex = paramMap[paramName]
         ;[
           createArgs(paramName, paramName),
@@ -152,6 +157,7 @@ describe('PackageURL', () => {
         ].forEach(args => {
           const message = JSON.stringify(args[paramIndex])
           try {
+            // eslint-disable-next-line no-new
             new PackageURL(...args)
             assert.ok(true, message)
           } catch {
@@ -160,7 +166,8 @@ describe('PackageURL', () => {
         })
       }
 
-      const testInvalid = paramName => {
+      // eslint-disable-next-line unicorn/consistent-function-scoping
+      function testInvalid(paramName) {
         const paramIndex = paramMap[paramName]
         ;[
           createArgs(paramName, 0),
@@ -171,6 +178,7 @@ describe('PackageURL', () => {
         ].forEach(args => {
           const message = JSON.stringify(args[paramIndex])
           try {
+            // eslint-disable-next-line no-new
             new PackageURL(...args)
             assert.ok(false, message)
           } catch {
@@ -179,10 +187,10 @@ describe('PackageURL', () => {
         })
       }
 
-      ;['namespace', 'version', 'subpath'].forEach(paramName => {
+      for (const paramName of ['namespace', 'version', 'subpath']) {
         testValid(paramName)
         testInvalid(paramName)
-      })
+      }
     })
 
     it('should not decode params', () => {
@@ -489,7 +497,7 @@ describe('PackageURL', () => {
             const parts = builtinName.split('/')
             const namespace = parts.length > 1 ? parts[0] : ''
             const name = parts.at(-1)
-
+            // eslint-disable-next-line no-new
             new PackageURL('npm', namespace, name)
           }, `assert for ${builtinName}`)
         }