Skip to content

Commit ca4739c

Browse files
committed
Cleaned up compile-time configuration flags.
1 parent 8233d90 commit ca4739c

File tree

4 files changed

+20
-14
lines changed

4 files changed

+20
-14
lines changed

firmware/nRF51/tag-proximity/inc/config.h

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,16 @@
2626
#define __CONFIG_H__
2727

2828
/* log to flash */
29-
#define CONFIG_FLASH_LOGGING 1
29+
#define CONFIG_FLASH_LOGGING 1
3030

3131
/* blink on receiving a proximity packet */
32-
#define PROXIMITY_BLINK 0
32+
#define CONFIG_PROXIMITY_BLINK 0
3333

3434
/* if epoch is invalid, pick up time from proximity packet */
35-
#define PROXIMITY_TIME 1
35+
#define CONFIG_EPOCH_PROXIMITY 1
36+
37+
/* double blink on invalid epoch time */
38+
#define CONFIG_EPOCH_INVALID_BLINK 1
3639

3740
/* every CONFIG_PROX_SPACING-RANDOM(2^CONFIG_PROX_SPACING_RNG_BITS)
3841
* listen for CONFIG_PROX_LISTEN - all based on LF_FREQUENCY ticks */

firmware/nRF51/tag-proximity/inc/openbeacon-proto.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,12 @@
4141

4242
#define FLAG_BOOT (1 << 0)
4343
#define FLAG_TIME_RESET (1 << 1)
44-
#define FLAG_LOG_STOPPED (1 << 2)
45-
#define ERROR_FLASH_WRITE (1 << 3)
46-
#define ERROR_LOG_BUF_OVERRUN (1 << 4)
47-
#define ERROR_LOG_COMPRESS (1 << 5)
48-
#define ERROR_FLASH_FULL (1 << 6)
44+
#define FLAG_HIBERNATE (1 << 2)
45+
#define FLAG_LOG_STOPPED (1 << 3)
46+
#define ERROR_FLASH_WRITE (1 << 4)
47+
#define ERROR_LOG_BUF_OVERRUN (1 << 5)
48+
#define ERROR_LOG_COMPRESS (1 << 6)
49+
#define ERROR_FLASH_FULL (1 << 7)
4950

5051

5152
typedef struct

firmware/nRF51/tag-proximity/src/main.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ void main_entry(void)
206206
timer_wait(MILLISECONDS(1));
207207
nrf_gpio_pin_clear(CONFIG_LED_PIN);
208208

209+
#if CONFIG_EPOCH_INVALID_BLINK
209210
/* double blink if epoch time is invalid */
210211
if (get_time() < VALID_EPOCH_THRES) {
211212
timer_wait(MILLISECONDS(100));
@@ -214,6 +215,7 @@ void main_entry(void)
214215
timer_wait(MILLISECONDS(1));
215216
nrf_gpio_pin_clear(CONFIG_LED_PIN);
216217
}
218+
#endif /* CONFIG_EPOCH_INVALID_BLINK */
217219
}
218220
}
219221
}

firmware/nRF51/tag-proximity/src/radio.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ void RTC0_IRQ_Handler(void)
193193
/* stop HF clock */
194194
NRF_CLOCK->TASKS_HFCLKSTOP = 1;
195195

196-
#if PROXIMITY_BLINK
196+
#if CONFIG_PROXIMITY_BLINK
197197
if(g_nrf_state == NRF_STATE_RX_PROX_BLINK)
198198
{
199199
g_nrf_state = NRF_STATE_IDLE;
@@ -203,7 +203,7 @@ void RTC0_IRQ_Handler(void)
203203
NRF_RTC0->CC[2] = NRF_RTC0->COUNTER + MILLISECONDS(1);
204204
}
205205
else
206-
#endif /*PROXIMITY_BLINK*/
206+
#endif /* CONFIG_PROXIMITY_BLINK */
207207
{
208208
/* set next state */
209209
g_nrf_state = NRF_STATE_IDLE;
@@ -212,10 +212,10 @@ void RTC0_IRQ_Handler(void)
212212
/* disable DC-DC converter */
213213
NRF_POWER->DCDCEN = 0;
214214

215-
#if PROXIMITY_BLINK
215+
#if CONFIG_PROXIMITY_BLINK
216216
/* disable LED */
217217
nrf_gpio_pin_clear(CONFIG_LED_PIN);
218-
#endif /*PROXIMITY_BLINK*/
218+
#endif /* CONFIG_PROXIMITY_BLINK */
219219
}
220220
}
221221
}
@@ -271,14 +271,14 @@ static void radio_on_prox_packet(uint16_t delta_t)
271271
if(g_pkt_prox_rx.p.prox.uid == g_pkt_prox.p.prox.uid)
272272
return;
273273

274-
#if PROXIMITY_TIME
274+
#if CONFIG_EPOCH_PROXIMITY
275275
/* if we lack a valid epoch time, get it from proximity packet */
276276
if ( g_time < VALID_EPOCH_THRES && g_pkt_prox_rx.p.prox.epoch > VALID_EPOCH_THRES )
277277
{
278278
g_time = g_pkt_prox_rx.p.prox.epoch;
279279
status_flags |= FLAG_TIME_RESET;
280280
}
281-
#endif /* PROXIMITY_TIME */
281+
#endif /* CONFIG_EPOCH_PROXIMITY */
282282

283283
/* maintain epoch time offset */
284284
if(g_pkt_prox_rx.p.prox.epoch > (g_time+g_time_offset))

0 commit comments

Comments
 (0)