Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstreaming wxwidgets #228

Open
Ckath opened this issue Jul 16, 2021 · 3 comments
Open

upstreaming wxwidgets #228

Ckath opened this issue Jul 16, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@Ckath
Copy link
Contributor

Ckath commented Jul 16, 2021

currently wxwidgets is obtained from https://github.com/audacity/wxwidgets, it'd be far better if this was just upstream wxwidgets or at least a sneed owned fork.
on first inspection the two dont seem to differ much but just swapping them out instantly runs into some issues, see the wxwidgets branch for more.

still not sure if it'll be possible to upstream entirely or if a fork is needed, but we'll find out.

opened after conan was pretty much gone as successor of #47

@Ckath Ckath added enhancement New feature or request help wanted Extra attention is needed labels Jul 16, 2021
@Ckath
Copy link
Contributor Author

Ckath commented Jul 20, 2021

seems its not that bad, just messing around it builds with upstream v3.1.5, as is. without too many issues besides the appimage ci generates being broken and it not working out yet on windows (which might also be my cmake files)
image

probably ideal to get it going with v3.0.5 since distros ship with that, but for the 'just lock it at some commit with a submodule' approach there might be hope for v3.1.5

@Ckath
Copy link
Contributor Author

Ckath commented Jul 30, 2021

as for the non distro supplied option and just going with a newer wxwidgets:
the build with 3.1.3 (which the audacity fork is based on), 3.1.4 and 3.1.5 all end in segfault on appimage launch, for me anyway. though they all run built locally. I'm not sure if anyone tested the mac builds. windows fails on some linking error I'm not sure I can easily solve without a windows system.

on second thought I'm also not really fond of patching in 3.0.5 compatability either with how far behind upstream that is, unless its ensured distros will stay on that for ages to come.

@ImGonnaChuck ImGonnaChuck added the documentation Improvements or additions to documentation label Mar 24, 2022
@ImGonnaChuck
Copy link
Contributor

To even begin to work on this we need to know and document the differences between the stock and the modified versions of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants