Skip to content

Commit 13c6658

Browse files
abaphnascGitHub Enterprise
authored and
GitHub Enterprise
committed
Merge pull request #5 from abaphna/arashp.flutter.pod
Fix pod and bundle id
2 parents d4f16e2 + d8c0bef commit 13c6658

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

ios/Podfile

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,20 @@ end
2727

2828
require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)
2929

30-
flutter_ios_podfile_setup
30+
sdk_path = File.expand_path("..", Dir.pwd)
31+
sdk_version_file_path = File.join(sdk_path, 'VERSION')
32+
sdk_version = File.read(sdk_version_file_path).strip
33+
34+
if sdk_version.empty?
35+
raise "SDK version must be specified in VERSION file"
36+
end
3137

3238
target 'Runner' do
3339
use_frameworks!
3440
use_modular_headers!
3541

36-
pod 'SCSDKCameraKit', '1.26.0'
37-
pod 'SCSDKCameraKitReferenceUI', '1.26.0'
42+
pod 'SCSDKCameraKit', sdk_version
43+
pod 'SCSDKCameraKitReferenceUI', sdk_version
3844

3945
flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
4046
end

ios/Runner.xcodeproj/project.pbxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@
377377
"$(inherited)",
378378
"@executable_path/Frameworks",
379379
);
380-
PRODUCT_BUNDLE_IDENTIFIER = com.camerakit.flutter.camerakitFlutterSampleSimple;
380+
PRODUCT_BUNDLE_IDENTIFIER = com.camerakit.sample.simple;
381381
PRODUCT_NAME = "$(TARGET_NAME)";
382382
SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h";
383383
SWIFT_VERSION = 5.0;
@@ -507,7 +507,7 @@
507507
"$(inherited)",
508508
"@executable_path/Frameworks",
509509
);
510-
PRODUCT_BUNDLE_IDENTIFIER = com.camerakit.flutter.camerakitFlutterSampleSimple;
510+
PRODUCT_BUNDLE_IDENTIFIER = com.camerakit.sample.simple;
511511
PRODUCT_NAME = "$(TARGET_NAME)";
512512
SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h";
513513
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
@@ -531,7 +531,7 @@
531531
"$(inherited)",
532532
"@executable_path/Frameworks",
533533
);
534-
PRODUCT_BUNDLE_IDENTIFIER = com.camerakit.flutter.camerakitFlutterSampleSimple;
534+
PRODUCT_BUNDLE_IDENTIFIER = com.camerakit.sample.simple;
535535
PRODUCT_NAME = "$(TARGET_NAME)";
536536
SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h";
537537
SWIFT_VERSION = 5.0;

ios/Runner/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
<key>CFBundleDevelopmentRegion</key>
66
<string>$(DEVELOPMENT_LANGUAGE)</string>
77
<key>CFBundleDisplayName</key>
8-
<string>Camerakit Flutter Sample Simple</string>
8+
<string>Camerakit Sample Simple</string>
99
<key>CFBundleExecutable</key>
1010
<string>$(EXECUTABLE_NAME)</string>
1111
<key>CFBundleIdentifier</key>
1212
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1313
<key>CFBundleInfoDictionaryVersion</key>
1414
<string>6.0</string>
1515
<key>CFBundleName</key>
16-
<string>camerakit_flutter_sample_simple</string>
16+
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1717
<key>CFBundlePackageType</key>
1818
<string>APPL</string>
1919
<key>CFBundleShortVersionString</key>

0 commit comments

Comments
 (0)