Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @skyscanner/stylelint-config-skyscanner from 6.0.2 to 11.1.0 #263

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+3,988 −2,635
Open

Bump @skyscanner/stylelint-config-skyscanner from 6.0.2 to 11.1.0 #263

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbba02c
Bump @skyscanner/stylelint-config-skyscanner from 6.0.2 to 11.1.0
dependabot[bot] Jan 19, 2024
ace1e25
use correct registry
metalix2 Jan 19, 2024
e7d118b
remove unnecessary plugins
metalix2 Jan 19, 2024
e9f026c
remove unnecessary plugins
metalix2 Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"parser": "babel-eslint",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer exists

"parser": "@babel/eslint-parser",
"extends": [
"@skyscanner/eslint-config-skyscanner",
"plugin:flowtype/recommended"
"plugin:ft-flow/recommended"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successor - https://www.npmjs.com/package/eslint-plugin-ft-flow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this one as we don't use flow in this repo anymore

],
"plugins": [
"flowtype"
"ft-flow",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

"eslint-plugin-prettier"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency missing?

ESLint couldn't find the plugin "eslint-plugin-prettier".

(The package "eslint-plugin-prettier" was not found when loaded as a Node module from the directory "/Users/matthewr/Code/backpack-foundations".)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should come from @skyscanner/eslint-config-skyscanner that is installed as a dep

],
"settings": {
"import/resolver": {
Expand Down
Loading
Loading