Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @skyscanner/stylelint-config-skyscanner from 6.0.2 to 11.1.0 #263

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 19, 2024

Bumps @skyscanner/stylelint-config-skyscanner from 6.0.2 to 11.1.0.

Release notes

Sourced from @​skyscanner/stylelint-config-skyscanner's releases.

11.1.0

What’s Changed

Added

11.0.0

What’s Changed

Breaking

Added

Fixed

Dependency updates

10.2.0

What’s Changed

Updated

10.1.0

What’s Changed

... (truncated)

Changelog

Sourced from @​skyscanner/stylelint-config-skyscanner's changelog.

Change Log

If @skyscanner/eslint-config-skyscanner has a major version change then @skyscanner/stylelint-config-skyscanner should also have a major version change, as explained in the docs

This file remains for historical references, but all new releases are now documented in the package's Releases page.

The format is based on Keep a Changelog and this project adheres to Semantic Versioning.

9.0.0

  • Update @​skyscanner/eslint-config-skyscanner to v15.0.0

This triggers a major version bump of @​skyscanner/stylelint-config-skyscanner due to https://github.com/Skyscanner/stylelint-config-skyscanner/blob/main/docs/eslint-as-dependency.md.

No changes are expected to CSS linting.

8.0.0

  • Update @​skyscanner/eslint-config-skyscanner to v14.0.0

This triggers a major version bump of @​skyscanner/stylelint-config-skyscanner due to https://github.com/Skyscanner/stylelint-config-skyscanner/blob/main/docs/eslint-as-dependency.md.

No changes are expected to CSS linting.

7.1.0

Updated

  • Bump jest from 27.5.1 to 29.4.3
  • Bump minimatch from 3.0.4 to 3.1.2 (security vulnerability)
  • Bump husky from 7.0.4 to 8.0.3
  • Bump lint-staged from 12.3.8 to 13.1.2
  • Bump stylelint-declaration-strict-value from 1.8.0 to 1.9.2
  • Bump stylelint-order from 5.0.0 to 6.0.2
  • Bump stylelint-scss from 4.1.0 to 4.4.0
  • Bump stylelint from 14.3.0 to 14.16.1

7.0.0

Updated

  • Bump @​skyscanner/eslint-config-skyscanner from 12.6.1 to 13.1.0
  • Bump stylelint-config-prettier from 9.0.3 to 9.0.4
  • Bump json5 from 1.0.1 to 1.0.2 (security bump)

As @skyscanner/eslint-config-skyscanner is shipped as dependency then this may cause JavaScript linting changes in your project as a side effect if you have not already updated. If that is the case it is the recommendation to first update @skyscanner/eslint-config-skyscanner and follow its release notes.

6.1.0 (deprecated)

Updated

... (truncated)

Commits
  • 8e41635 Replaced at-import-no-partial-leading-underscore with load-no-partial-leading...
  • 2716aef [NOJIRA] update version of checkout action in test workflow (#325)
  • dbd66b0 Bump lint-staged from 15.0.2 to 15.2.0 (#321)
  • 7823d93 Bump stylelint-scss from 5.3.1 to 5.3.2 (#322)
  • 988ee7d Bump @​skyscanner/eslint-config-skyscanner from 17.0.0 to 17.1.0 (#323)
  • ff555aa Bump stylelint-order from 6.0.3 to 6.0.4 (#324)
  • 67af56f Bump stylelint-scss from 5.3.0 to 5.3.1 (#319)
  • b58ee8c Bump stylelint-config-standard-scss from 10.0.0 to 11.1.0 (#316)
  • e067cd4 Bump @​skyscanner/eslint-config-skyscanner from 16.3.0 to 17.0.0 (#315)
  • b65bdff Bump stylelint-scss from 4.4.0 to 5.3.0 (#314)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by skyscanner-koalasquad, a new releaser for @​skyscanner/stylelint-config-skyscanner since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 19, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/skyscanner/stylelint-config-skyscanner-11.1.0 branch 3 times, most recently from ac3e735 to 9d3bcef Compare January 19, 2024 10:35
@metalix2
Copy link
Contributor

@dependabot rebase

Bumps [@skyscanner/stylelint-config-skyscanner](https://github.com/Skyscanner/stylelint-config-skyscanner) from 6.0.2 to 11.1.0.
- [Release notes](https://github.com/Skyscanner/stylelint-config-skyscanner/releases)
- [Changelog](https://github.com/Skyscanner/stylelint-config-skyscanner/blob/main/CHANGELOG.md)
- [Commits](Skyscanner/stylelint-config-skyscanner@v6.0.2...11.1.0)

---
updated-dependencies:
- dependency-name: "@skyscanner/stylelint-config-skyscanner"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/skyscanner/stylelint-config-skyscanner-11.1.0 branch from 9d3bcef to fbba02c Compare January 19, 2024 10:52
@@ -1,11 +1,12 @@
{
"parser": "babel-eslint",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer exists

.eslintrc.json Outdated
"plugin:flowtype/recommended"
"plugin:ft-flow/recommended"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this one as we don't use flow in this repo anymore

.eslintrc.json Outdated
],
"plugins": [
"flowtype"
"ft-flow",
"eslint-plugin-prettier"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency missing?

ESLint couldn't find the plugin "eslint-plugin-prettier".

(The package "eslint-plugin-prettier" was not found when loaded as a Node module from the directory "/Users/matthewr/Code/backpack-foundations".)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should come from @skyscanner/eslint-config-skyscanner that is installed as a dep

@metalix2 metalix2 force-pushed the dependabot/npm_and_yarn/skyscanner/stylelint-config-skyscanner-11.1.0 branch from 05d0e85 to ace1e25 Compare January 19, 2024 11:55
.eslintrc.json Outdated
],
"plugins": [
"flowtype"
"ft-flow",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

package.json Outdated
@@ -71,7 +72,8 @@
"babel-loader": "^8.3.0",
"css-loader": "^1.0.0",
"del": "^5.0.0",
"eslint-plugin-flowtype": "^4.7.0",
"eslint-plugin-ft-flow": "^3.0.2",
"eslint-plugin-prettier": "^5.1.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed as it will be coming from @skyscanner/eslint-config-skyscanner, that comes as part of the stylelint config skyscanner

Copy link
Member

@olliecurtis olliecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the comments around libs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants