New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ginkgo async testing #57

Closed

maruina wants to merge 2 commits into main from fix-gingko

Contributor

maruina commented Apr 13, 2021

Fix #56

maruina added 2 commits

April 13, 2021 10:51


          Fix ginkgo async testing

faa51b4


          Merge branch 'main' into fix-gingko

258e698

Contributor Author

maruina commented Apr 13, 2021

After having a chat in the #kubebuilder channel, it seems there are some changes needed in the controller-runtime itself before making this change. See https://kubernetes.slack.com/archives/CAR30FCJZ/p1618306852445800 for more context.

Closing for the time being.

maruina closed this

maruina deleted the fix-gingko branch

May 14, 2021 15:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet