Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maxTargets and maxParallel with % values #112

Open
maruina opened this issue Jun 30, 2021 · 0 comments
Open

Support maxTargets and maxParallel with % values #112

maruina opened this issue Jun 30, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@maruina
Copy link
Contributor

maruina commented Jun 30, 2021

The ProgressiveSync CRD is designed as to support maxTargets and maxParallel as IntOrString.

Consider the following scenario, when you have 4 clusters and a ProgressiveSync similar to

[...]
stages:
  - name: one cluster
     maxTargets: 1
     maxParallel: 1
     targets:
       clusters:
         selector:
           name: cluster-one
  - name: everything else
     maxTargets: 100%
     maxParallel: 25%
     targets:
       clusters:
         selector: {}

In the second stage, we would expect maxTargets to be 3, but instead we set it to 4. This is because the scheduler looks at every application matching the label selector - in this case all of them.

We need to change this logic so when we express maxTargets and maxParallel as %, they are scaled against the remaining clusters.

@maruina maruina added the bug Something isn't working label Jun 30, 2021
@maruina maruina added this to the Milestone 2 milestone Jun 30, 2021
@maruina maruina modified the milestones: Milestone 2, Milestone 3 Aug 12, 2021
@Smirl Smirl mentioned this issue Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant