Skip to content

Commit a98115e

Browse files
committed
No longer request cookies if the user has refused
1 parent da86ac7 commit a98115e

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

Diff for: docs/templates/js/functions.js

+12-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,16 @@
1-
let isCookiesAccepted = getCookie("cookies-accepted") === "true";
2-
31
// <> Cookies
2+
3+
// Returns whether the user has accepted the cookies or not, or undefined if the user hasn't chosen yet
4+
function isCookiesAccepted() {
5+
const cookie = getCookie("cookies-accepted");
6+
if (!cookie) {
7+
return undefined;
8+
}
9+
return Boolean(cookie);
10+
}
11+
412
function setCookie(cname, cvalue, exdays, force = false) {
5-
if (!isCookiesAccepted && !force)
13+
if (!isCookiesAccepted() && !force)
614
return;
715

816
const d = new Date();
@@ -37,7 +45,7 @@ function getCookie(cname) {
3745
* @param {double} exdays time in days
3846
*/
3947
function setStorageItem(item, value, exdays, force = false) {
40-
if (!isCookiesAccepted && !force)
48+
if (!isCookiesAccepted() && !force)
4149
return;
4250

4351
const d = new Date();

Diff for: docs/templates/js/main.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ if (examples) {
389389
// Example Collapse </>
390390

391391
// <> Cookies Accecpt
392-
if (!isCookiesAccepted) {
392+
if (isCookiesAccepted() === undefined) {
393393
document.body.insertAdjacentHTML('beforeend', `<div id="cookies-bar"> <p> We use cookies and local storage to enhance your browsing experience and store github related statistics. By clicking "Accept", you consent to our use of cookies and local storage. </p><div style="padding: 10px; white-space: nowrap;"> <button id="cookies-accept">Accept</button> <button id="cookies-deny">Deny</button> </div></div>`);
394394
}
395395

@@ -402,6 +402,7 @@ if (cookiesAccept && cookiesDeny) {
402402
cookiesBar.remove();
403403
});
404404
cookiesDeny.addEventListener('click', () => {
405+
setCookie('cookies-accepted', false, 99, true);
405406
cookiesBar.remove();
406407
});
407408
}

0 commit comments

Comments
 (0)