Fix various lints (google#1507)

* Replace interface{} with any

* Add godoc comments

* Add missing err check

* gofmt

* Bump things to 1.18

* Update staticcheck, drop golint

* Fix io/ioutil deprecation

* Run gofmt

* boilerplate

Author: jonjohnsonjr

.github/workflows/build.yaml

@@ -12,7 +12,7 @@ jobs:
 
     strategy:
       matrix:
-        go-version: [1.18] # TODO: add 1.19
+        go-version: [1.18, 1.19] # TODO: add 1.20
 
     steps:
       - uses: actions/checkout@v3

.github/workflows/release.yml

@@ -15,7 +15,7 @@ jobs:
         run: git fetch --prune --unshallow
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version: 1.18
           check-latest: true
       - uses: goreleaser/[email protected]
         id: run-goreleaser

.github/workflows/test.yaml

@@ -11,7 +11,7 @@ jobs:
   test:
     strategy:
       matrix:
-        go-version: [1.18] # TODO: add 1.19
+        go-version: [1.18, 1.19] # TODO: add 1.20
 
     name: Unit Tests
     runs-on: ubuntu-latest

cmd/crane/cmd/auth.go

@@ -18,7 +18,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"log"
 	"os"
 	"strings"
@@ -86,7 +86,7 @@ func NewCmdAuthGet(options []crane.Option, argv ...string) *cobra.Command {
 			if len(args) == 1 {
 				registryAddr = args[0]
 			} else {
-				b, err := ioutil.ReadAll(os.Stdin)
+				b, err := io.ReadAll(os.Stdin)
 				if err != nil {
 					return err
 				}
@@ -170,7 +170,7 @@ type loginOptions struct {
 
 func login(opts loginOptions) error {
 	if opts.passwordStdin {
-		contents, err := ioutil.ReadAll(os.Stdin)
+		contents, err := io.ReadAll(os.Stdin)
 		if err != nil {
 			return err
 		}

cmd/crane/cmd/export.go

@@ -17,7 +17,6 @@ package cmd
 import (
 	"fmt"
 	"io"
-	"io/ioutil"
 	"log"
 	"os"
 
@@ -55,7 +54,7 @@ func NewCmdExport(options *[]crane.Option) *cobra.Command {
 
 			var img v1.Image
 			if src == "-" {
-				tmpfile, err := ioutil.TempFile("", "crane")
+				tmpfile, err := os.CreateTemp("", "crane")
 				if err != nil {
 					log.Fatal(err)
 				}

cmd/crane/cmd/push.go

@@ -16,7 +16,6 @@ package cmd
 
 import (
 	"fmt"
-	"io/ioutil"
 	"os"
 
 	"github.com/google/go-containerregistry/pkg/crane"
@@ -72,7 +71,7 @@ func NewCmdPush(options *[]crane.Option) *cobra.Command {
 
 			digest := ref.Context().Digest(h.String())
 			if imageRefs != "" {
-				return ioutil.WriteFile(imageRefs, []byte(digest.String()), 0600)
+				return os.WriteFile(imageRefs, []byte(digest.String()), 0600)
 			}
 			// TODO(mattmoor): think about printing the digest to standard out
 			// to facilitate command composition similar to ko build.

cmd/crane/cmd/root.go

@@ -1,3 +1,5 @@
+// Copyright 2019 Google LLC All Rights Reserved.
+//
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at

cmd/crane/cmd/util.go

@@ -1,3 +1,17 @@
+// Copyright 2020 Google LLC All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 package cmd
 
 import (

cmd/crane/cmd/version.go

@@ -1,3 +1,17 @@
+// Copyright 2019 Google LLC All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 package cmd
 
 import (

cmd/crane/help/main.go

@@ -1,3 +1,17 @@
+// Copyright 2018 Google LLC All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 package main
 
 import (