Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log registers status change while this did not happen #136

Open
someren opened this issue Mar 5, 2021 · 1 comment
Open

Log registers status change while this did not happen #136

someren opened this issue Mar 5, 2021 · 1 comment

Comments

@someren
Copy link

someren commented Mar 5, 2021

After changing the categorie of a signal, the log also registers that the status of the signal has been altered.
This is incorrect and makes the logging unreliable.
It is even impossible to change the status and categorie at the same time.

  1. Open a signal/ticket
  2. Click on the pensil to change the categorie
  3. Click on "Opslaan"
  4. The logging shows two new lines: a correct one with the categorie change and a faulty one with status change.

Opened a signal:

Logging status change 1

Changed the categorie (not status!) but logging shows otherwise:

Logging status change 2

Can you please fix this?

@CBuiVNG
Copy link

CBuiVNG commented Mar 11, 2021

It turns out that the FE always sends out an status update 'm' along with the category update.

{"status":{"state":"m"},"category":{"sub_category":"http://localhost:8000/signals/v1/public/terms/categories/dieren/sub_categories/dood-dier"}}

So we honor the request, don't know if this is intentional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants