From 93248d4e4950c2ad6b228fd31ba80fad9483534e Mon Sep 17 00:00:00 2001 From: vikrantgupta25 Date: Fri, 13 Sep 2024 01:41:03 +0530 Subject: [PATCH] feat: enable the search v2 for logs explorer page and remove FF --- ee/query-service/model/plans.go | 22 ----------------- .../LogExplorerQuerySection/index.tsx | 24 ++++--------------- .../QueryBuilder/components/Query/Query.tsx | 23 ++++++++++++++---- 3 files changed, 23 insertions(+), 46 deletions(-) diff --git a/ee/query-service/model/plans.go b/ee/query-service/model/plans.go index dbd8b56965..9b696c013f 100644 --- a/ee/query-service/model/plans.go +++ b/ee/query-service/model/plans.go @@ -13,7 +13,6 @@ const Onboarding = "ONBOARDING" const ChatSupport = "CHAT_SUPPORT" const Gateway = "GATEWAY" const PremiumSupport = "PREMIUM_SUPPORT" -const QueryBuilderSearchV2 = "QUERY_BUILDER_SEARCH_V2" var BasicPlan = basemodel.FeatureSet{ basemodel.Feature{ @@ -128,13 +127,6 @@ var BasicPlan = basemodel.FeatureSet{ UsageLimit: -1, Route: "", }, - basemodel.Feature{ - Name: QueryBuilderSearchV2, - Active: false, - Usage: 0, - UsageLimit: -1, - Route: "", - }, } var ProPlan = basemodel.FeatureSet{ @@ -243,13 +235,6 @@ var ProPlan = basemodel.FeatureSet{ UsageLimit: -1, Route: "", }, - basemodel.Feature{ - Name: QueryBuilderSearchV2, - Active: false, - Usage: 0, - UsageLimit: -1, - Route: "", - }, } var EnterprisePlan = basemodel.FeatureSet{ @@ -372,11 +357,4 @@ var EnterprisePlan = basemodel.FeatureSet{ UsageLimit: -1, Route: "", }, - basemodel.Feature{ - Name: QueryBuilderSearchV2, - Active: false, - Usage: 0, - UsageLimit: -1, - Route: "", - }, } diff --git a/frontend/src/container/LogExplorerQuerySection/index.tsx b/frontend/src/container/LogExplorerQuerySection/index.tsx index f807103f68..c49990861f 100644 --- a/frontend/src/container/LogExplorerQuerySection/index.tsx +++ b/frontend/src/container/LogExplorerQuerySection/index.tsx @@ -1,6 +1,5 @@ import './LogsExplorerQuerySection.styles.scss'; -import { FeatureKeys } from 'constants/features'; import { initialQueriesMap, OPERATORS, @@ -9,14 +8,12 @@ import { import ExplorerOrderBy from 'container/ExplorerOrderBy'; import { QueryBuilder } from 'container/QueryBuilder'; import { OrderByFilterProps } from 'container/QueryBuilder/filters/OrderByFilter/OrderByFilter.interfaces'; -import QueryBuilderSearch from 'container/QueryBuilder/filters/QueryBuilderSearch'; import QueryBuilderSearchV2 from 'container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2'; import { QueryBuilderProps } from 'container/QueryBuilder/QueryBuilder.interfaces'; import { useGetPanelTypesQueryParam } from 'hooks/queryBuilder/useGetPanelTypesQueryParam'; import { useQueryBuilder } from 'hooks/queryBuilder/useQueryBuilder'; import { useQueryOperations } from 'hooks/queryBuilder/useQueryBuilderOperations'; import { useShareBuilderUrl } from 'hooks/queryBuilder/useShareBuilderUrl'; -import useFeatureFlags from 'hooks/useFeatureFlag'; import { prepareQueryWithDefaultTimestamp, SELECTED_VIEWS, @@ -89,26 +86,15 @@ function LogExplorerQuerySection({ [handleChangeQueryData], ); - const isSearchV2Enabled = - useFeatureFlags(FeatureKeys.QUERY_BUILDER_SEARCH_V2)?.active || false; - return ( <> {selectedView === SELECTED_VIEWS.SEARCH && (
- {isSearchV2Enabled ? ( - - ) : ( - - )} +
)} diff --git a/frontend/src/container/QueryBuilder/components/Query/Query.tsx b/frontend/src/container/QueryBuilder/components/Query/Query.tsx index 747198abfb..453cf063f8 100644 --- a/frontend/src/container/QueryBuilder/components/Query/Query.tsx +++ b/frontend/src/container/QueryBuilder/components/Query/Query.tsx @@ -23,6 +23,7 @@ import { import AggregateEveryFilter from 'container/QueryBuilder/filters/AggregateEveryFilter'; import LimitFilter from 'container/QueryBuilder/filters/LimitFilter/LimitFilter'; import QueryBuilderSearch from 'container/QueryBuilder/filters/QueryBuilderSearch'; +import QueryBuilderSearchV2 from 'container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2'; import { useQueryBuilder } from 'hooks/queryBuilder/useQueryBuilder'; import { useQueryOperations } from 'hooks/queryBuilder/useQueryBuilderOperations'; // ** Hooks @@ -81,6 +82,10 @@ export const Query = memo(function Query({ entityVersion: version, }); + const isLogsExplorerPage = useMemo(() => pathname === ROUTES.LOGS_EXPLORER, [ + pathname, + ]); + const handleChangeAggregateEvery = useCallback( (value: IBuilderQuery['stepInterval']) => { handleChangeQueryData('stepInterval', value); @@ -452,11 +457,19 @@ export const Query = memo(function Query({ )} - + {isLogsExplorerPage ? ( + + ) : ( + + )}