Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we set global.registry to all componts #493

Open
dmsolr opened this issue Sep 2, 2024 · 2 comments
Open

Should we set global.registry to all componts #493

dmsolr opened this issue Sep 2, 2024 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@dmsolr
Copy link

dmsolr commented Sep 2, 2024

I found some components set a hard code 'docker.io' as registry, should we set them to global.registry?

@grandwizard28
Copy link
Contributor

Hi @dmsolr,
Which components are you referring to?

@grandwizard28 grandwizard28 added the question Further information is requested label Sep 19, 2024
@grandwizard28 grandwizard28 self-assigned this Sep 19, 2024
@dmsolr
Copy link
Author

dmsolr commented Oct 1, 2024

Here is an example,

queryService:
name: "query-service"
replicaCount: 1
image:
registry: docker.io
repository: signoz/query-service

This is a self-hosted component, the query service, and many components, such as initContainers, use docker.io as the image repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants