New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otel-agent: varlibdockercontainers is not always relevant #379

Open

zimbatm opened this issue Jan 14, 2024 · 1 comment

Assignees

Labels

chart:k8s-infra enhancement good first issue

Contributor

zimbatm commented Jan 14, 2024

charts/charts/k8s-infra/templates/otel-agent/daemonset.yaml

Lines 118 to 122 in 7e7b159

    
           {{- if ne .Values.global.cloud "gcp/autogke" }} 
        
           - name: varlibdockercontainers 
        
             mountPath: /var/lib/docker/containers 
        
             readOnly: true 
        
           {{- end }}

This option should probably be globally configurable. Depending on your K8s installation, Docker is not present on the host (eg: RKE2).

prashant-shahi self-assigned this

prashant-shahi added the enhancement label

grandwizard28 added chart:k8s-infra good first issue labels

Contributor

grandwizard28 commented Oct 13, 2024

Hi @zimbatm,
Thanks for opening this issue! Would you be willing to contribute a PR for the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment