Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual mode support for mkdx#gf #119

Closed
SidOfc opened this issue Aug 30, 2020 · 1 comment
Closed

Add visual mode support for mkdx#gf #119

SidOfc opened this issue Aug 30, 2020 · 1 comment
Assignees
@SidOfc
Labels
feature:request Requesting new and additions to existing features.

Comments

@SidOfc
Copy link
Owner

SidOfc commented Aug 30, 2020

This feature request originates from #116, it would allow mkdx#gf to also function in visual mode.

Adding support for this has the following benefits:

  • non-link texts that refer to files / URL's can be selected visually and acted upon.
  • when the normal mode mapping fails, a visual selection can be made instead as a fallback.

This would only be enabled when g:mkdx#settings.gf_on_steroids is set to 1.
@SidOfc SidOfc added the feature:request Requesting new and additions to existing features. label Aug 30, 2020
@SidOfc SidOfc self-assigned this Aug 30, 2020
@SidOfc SidOfc mentioned this issue Aug 30, 2020
Closed
SidOfc added a commit that referenced this issue Sep 11, 2020
@SidOfc
Add support for visual mode gx/gf (#119)
790bfa5
@SidOfc SidOfc closed this as completed Sep 11, 2020
@SidOfc
Copy link
Owner Author

SidOfc commented Sep 11, 2020

Feature has been added, both gf and gx may now be used in visual mode as well.
I decided to enable them by default instead of only when g:mkdx#settings.gf_on_steroids is enabled to keep consistent normal mode mappings function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SidOfc SidOfc

Labels
feature:request Requesting new and additions to existing features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SidOfc