Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate potential host scanning race #1538

Open
ChrisSchinnerl opened this issue Sep 17, 2024 · 0 comments · Fixed by #1548
Open

Investigate potential host scanning race #1538

ChrisSchinnerl opened this issue Sep 17, 2024 · 0 comments · Fixed by #1548
Milestone
v2.1.0

Comments

@ChrisSchinnerl
Copy link
Member 

          Unrelated to this PR but do we have a race here? If offset is 0 and batch size 10 but then move the offset to 10 after already scanning 5 of those hosts, we might be skipping 5 hosts that haven't been scanned yet.

Originally posted by @ChrisSchinnerl in #1529 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Sia
Status: Todo
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Have scanner wait for batch to finish before starting a new one SiaFoundation/renterd
1 participant
@ChrisSchinnerl