Could remove block_id on wallet_transactions?

[kocoten1992]

Description

select block_id from wallet_transactions where block_id != null;

The result is empty, if this field is useless, may I remove it via migration (and some of the code related)?

Version

v1.1.1

What operating system are you running (e.g. Ubuntu 22.04, macOS, Windows 11)?

Debian 12.6

Anything else?

No response

[n8maninger]

That column is not useless. It’s used to revert transactions during a reorg.

hostd/persist/sqlite/wallet.go

Line 93 in d77583e

_, err := tx.tx.Exec(`DELETE FROM wallet_transactions WHERE block_id=?`, sqlHash256(blockID))