-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic announcement addresses #17
Comments
We will probably not add this. |
@pcfreak30 speaking of which -- any reason not to import the ipfs package from here? It looks like that file is a copy-paste of an older version with some minor additions. A wrapper would have gotten you the same effect with less maintenance overhead. |
I may adapt in the future, but at the time, it was not obvious how things would turn out in design. |
I thought this might be valuable as a config option to have it automatically compute the announcement addresses, in addition to the manual array.
You can see what I have done at https://github.com/LumeWeb/portal-plugin-ipfs/blob/ee574256baca31afc3eb6a0b354df30c6aef02af/internal/protocol/ipfs/node.go#L303
The text was updated successfully, but these errors were encountered: