Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic announcement addresses #17

Closed
pcfreak30 opened this issue Sep 18, 2024 · 3 comments
Closed

Automatic announcement addresses #17

pcfreak30 opened this issue Sep 18, 2024 · 3 comments

Comments

@pcfreak30
Copy link

pcfreak30 commented Sep 18, 2024

I thought this might be valuable as a config option to have it automatically compute the announcement addresses, in addition to the manual array.

You can see what I have done at https://github.com/LumeWeb/portal-plugin-ipfs/blob/ee574256baca31afc3eb6a0b354df30c6aef02af/internal/protocol/ipfs/node.go#L303

@n8maninger
Copy link
Member

n8maninger commented Sep 18, 2024

We will probably not add this. fsd is designed to be run as infrastructure where choices like this should be explicit.

@n8maninger n8maninger closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
@n8maninger
Copy link
Member

n8maninger commented Sep 18, 2024

@pcfreak30 speaking of which -- any reason not to import the ipfs package from here? It looks like that file is a copy-paste of an older version with some minor additions. A wrapper would have gotten you the same effect with less maintenance overhead.

@pcfreak30
Copy link
Author

@pcfreak30 speaking of which -- any reason not to import the ipfs package from here? It looks like that file is a copy-paste of an older version with some minor additions. A wrapper would have gotten you the same effect with less maintenance overhead.

I may adapt in the future, but at the time, it was not obvious how things would turn out in design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants