Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose fromArbitraryData and fromAttestation for HostAnnouncement #97

Closed
ChrisSchinnerl opened this issue Sep 19, 2024 · 0 comments · Fixed by #98
Closed

Expose fromArbitraryData and fromAttestation for HostAnnouncement #97

ChrisSchinnerl opened this issue Sep 19, 2024 · 0 comments · Fixed by #98
Assignees
@n8maninger

Comments

@ChrisSchinnerl
Copy link
Member

ChrisSchinnerl commented Sep 19, 2024 •
edited
Loading

Related to https://github.com/SiaFoundation/explored/pull/99/files#r1765898838

Might be useful to expose those helpers to avoid duplicate code. You don't always have access to a types.Block.
HostAnnouncement is also missing a json tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n8maninger n8maninger

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose From and To for host announcements SiaFoundation/coreutils
2 participants
@ChrisSchinnerl @n8maninger