Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better auto-closing pairs #202

Closed
charlespwd opened this issue Oct 25, 2023 · 4 comments · Fixed by #242
Closed

Better auto-closing pairs #202

charlespwd opened this issue Oct 25, 2023 · 4 comments · Fixed by #242
Labels
enhancement New feature or request

Comments

@charlespwd
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Echo of Shopify/theme-check-vscode#108

In PHPStorm Liquid the spaces are automatically added, this also kills my productivity 😄

Describe the solution you'd like
Better auto space pairs.
@charlespwd charlespwd added the enhancement New feature or request label Oct 25, 2023
@charlespwd
Copy link
Contributor Author

cc @bakura10

@charlespwd
Copy link
Contributor Author

The VS Code settings are a dead end. But it looks like there's an LSP-way of doing this:

@charlespwd
Copy link
Contributor Author

charlespwd commented Nov 8, 2023 •
edited
Loading

(Ugh editor.formatOnType is off by default, might need a different approach)

@charlespwd
Copy link
Contributor Author

Looks like we can change that ^
https://code.visualstudio.com/api/references/contribution-points#contributes.configurationDefaults

charlespwd added a commit that referenced this issue Nov 9, 2023
@charlespwd
Add better auto-closing UX for Liquid pairs
8d5945d 
Fixes #202
Fixes Shopify/theme-check-vscode#108
@charlespwd charlespwd mentioned this issue Nov 9, 2023
Merged
2 tasks
charlespwd added a commit that referenced this issue Nov 9, 2023
@charlespwd
Add better auto-closing UX for Liquid pairs
baa6d37 
Fixes #202
Fixes Shopify/theme-check-vscode#108
charlespwd added a commit that referenced this issue Nov 9, 2023
@charlespwd
Add better auto-closing UX for Liquid pairs
423b9cf 
Fixes #202
Fixes Shopify/theme-check-vscode#108

xoxo
charlespwd added a commit that referenced this issue Nov 9, 2023
@charlespwd
Add better auto-closing UX for Liquid pairs
df89242 
Fixes #202
Fixes Shopify/theme-check-vscode#108

xoxo
charlespwd added a commit that referenced this issue Nov 9, 2023
@charlespwd
Add better auto-closing UX for Liquid pairs
b7fbdc2 
Fixes #202
Fixes Shopify/theme-check-vscode#108

xoxo
charlespwd added a commit that referenced this issue Nov 9, 2023
@charlespwd
Add better auto-closing UX for Liquid pairs (#242)
a120393 
* Use typescript for the VS Code language config

* Add better auto-closing UX for Liquid pairs

Fixes #202
Fixes Shopify/theme-check-vscode#108

xoxo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add better auto-closing UX for Liquid pairs Shopify/theme-tools
1 participant
@charlespwd