Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

formatOnSave doesn't appear to fix wrapping and whitespace issues when liquid is within quotes or capture tag #119

Closed
alibosworth opened this issue Mar 10, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@alibosworth
Copy link

alibosworth commented Mar 10, 2023

I searched existing issues in theme-check-vscode and theme-check and couldn't find this, but apologies if it is somewhere and I failed to find it.

We're finding that formatOnSave is not working for a render tag within quotes, like this:

Screen Shot 2023-03-10 at 11 55 44 AM

It also appears not to work if within a capture tag like this:

Screen Shot 2023-03-10 at 11 52 11 AM

if it is outside of either of these situations like this:

Screen Shot 2023-03-10 at 11 52 31 AM

then upon save it is "correctly" autoformatted to be like this:

Screen Shot 2023-03-10 at 11 53 03 AM

My hunch is this is a problem with a theme-check rule, however when I disable "editor.formatOnSave": false, in VSC and run theme-check on this code, it doesn't raise an issue with any 3 of these scenarios, so I'm opening the issue on the VSC plugin directly. I'm happy to re-report this in a more appropriate place if someone can point me in the right direction

@mgmanzella mgmanzella added the bug Something isn't working label Jun 18, 2024
@mgmanzella
Copy link

possibly related Shopify/theme-tools#190

@mgmanzella
Copy link

if this is still an issue please open an issue in the theme tools repo, this repo is no longer the source of truth 🙏 thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants