Skip to content

Commit e764bee

Browse files
committed
Remove an erroneous assert
1 parent 520600a commit e764bee

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

zjit/src/hir.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1012,7 +1012,6 @@ impl Insn {
10121012
}
10131013

10141014
fn get_effects(&self) -> Effect {
1015-
assert!(self.has_output());
10161015
match &self {
10171016
Insn::Const { .. } => Effect::from_bits(effect_sets::Any, effect_sets::Allocator),
10181017
Insn::Param => Effect::from_bits(effect_sets::Any, effect_sets::Allocator),
@@ -1091,7 +1090,6 @@ impl Insn {
10911090
/// collapses to `effects::Allocator.includes(insn_effects.write)`.
10921091
/// Note: These are restrictions on the `write` `EffectSet` only. Even instructions with
10931092
/// `read: effects::Any` could potentially be omitted.
1094-
// TODO(Jacob): Ensure that `is_elidable` === `!has_effects` for all inputs
10951093
fn is_elidable(&self) -> bool {
10961094
let writes_allocator = Effect::from_bits(effect_sets::Any, effect_sets::Allocator);
10971095
writes_allocator.includes(self.get_effects())

0 commit comments

Comments
 (0)