Skip to content

Commit 8f4cf03

Browse files
authored
Merge pull request #632 from Shopify/language
keep linting to code
2 parents e9400e0 + 910e9ff commit 8f4cf03

File tree

2 files changed

+1
-27
lines changed

2 files changed

+1
-27
lines changed

rubocop.yml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -389,21 +389,6 @@ Naming/HeredocDelimiterCase:
389389
Naming/HeredocDelimiterNaming:
390390
Enabled: false
391391

392-
Naming/InclusiveLanguage:
393-
Enabled: true
394-
FlaggedTerms:
395-
master:
396-
Suggestions:
397-
- main
398-
- primary
399-
- leader
400-
AllowedRegex:
401-
- !ruby/regexp '/master[_\s\.]key/' # Rails master key
402-
- !ruby/regexp /\w*:\/\/\S+/ # URLs (e.g. https://github.com/org/repo/blob/master/README.md)
403-
- !ruby/regexp '/(?:blob|tree)/master/' # e.g. github.com/org/repo/blob/master/README.md, without https://
404-
- !ruby/regexp '/origin[ \/]master/' # Legacy default git branch name
405-
- !ruby/regexp '/(?<=[a-z])master|master(?=[a-z])/' # "master" substring within a longer word
406-
407392
Naming/MemoizedInstanceVariableName:
408393
Enabled: false
409394

test/fixtures/full_config.yml

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2141,7 +2141,7 @@ Naming/HeredocDelimiterNaming:
21412141
- !ruby/regexp /(^|\s)(EO[A-Z]{1}|END)(\s|$)/i
21422142
Naming/InclusiveLanguage:
21432143
Description: Recommend the use of inclusive language instead of problematic terms.
2144-
Enabled: true
2144+
Enabled: false
21452145
VersionAdded: '1.18'
21462146
VersionChanged: '1.49'
21472147
CheckIdentifiers: true
@@ -2168,17 +2168,6 @@ Naming/InclusiveLanguage:
21682168
- replica
21692169
- secondary
21702170
- follower
2171-
master:
2172-
Suggestions:
2173-
- main
2174-
- primary
2175-
- leader
2176-
AllowedRegex:
2177-
- !ruby/regexp /master[_\s\.]key/
2178-
- !ruby/regexp /\w*:\/\/\S+/
2179-
- !ruby/regexp /(?:blob|tree)\/master/
2180-
- !ruby/regexp /origin[ \/]master/
2181-
- !ruby/regexp /(?<=[a-z])master|master(?=[a-z])/
21822171
Naming/MemoizedInstanceVariableName:
21832172
Description: Memoized method name should match memo instance variable name.
21842173
Enabled: false

0 commit comments

Comments
 (0)