Skip to content

Commit 21d0f46

Browse files
committed
Drop support to Rubocop < 1.62
They don't support Ruby 3.4.
1 parent a7a7ae4 commit 21d0f46

File tree

4 files changed

+5
-50
lines changed

4 files changed

+5
-50
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ PATH
22
remote: .
33
specs:
44
rubocop-shopify (2.15.1)
5-
rubocop (~> 1.51)
5+
rubocop (~> 1.62)
66

77
GEM
88
remote: https://rubygems.org/

rubocop-shopify.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ Gem::Specification.new do |s|
2323

2424
s.required_ruby_version = ">= 3.1.0"
2525

26-
s.add_dependency("rubocop", "~> 1.51")
26+
s.add_dependency("rubocop", "~> 1.62")
2727
end

rubocop.yml

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -473,21 +473,17 @@ Lint/InheritException:
473473
Lint/InterpolationCheck:
474474
Enabled: false
475475

476-
<% if rubocop_version >= '1.59' %>
477476
Lint/ItWithoutArgumentsInBlock:
478477
Enabled: false
479-
<% end %>
480478

481479
Lint/LambdaWithoutLiteralBlock:
482480
Enabled: false
483481

484482
Lint/LiteralAsCondition:
485483
Enabled: false
486484

487-
<% if rubocop_version >= '1.58' %>
488485
Lint/LiteralAssignmentInCondition:
489486
Enabled: false
490-
<% end %>
491487

492488
Lint/LiteralInInterpolation:
493489
Enabled: false
@@ -501,10 +497,8 @@ Lint/MissingCopEnableDirective:
501497
Lint/MissingSuper:
502498
Enabled: false
503499

504-
<% if rubocop_version >= '1.53' %>
505500
Lint/MixedCaseRange:
506501
Enabled: false
507-
<% end %>
508502

509503
Lint/MixedRegexpCaptureTypes:
510504
Enabled: false
@@ -569,10 +563,8 @@ Lint/RedundantCopEnableDirective:
569563
Lint/RedundantDirGlobSort:
570564
Enabled: false
571565

572-
<% if rubocop_version >= '1.53' %>
573566
Lint/RedundantRegexpQuantifiers:
574567
Enabled: false
575-
<% end %>
576568

577569
Lint/RedundantRequireStatement:
578570
Enabled: false
@@ -1320,10 +1312,8 @@ Style/RandomWithOffset:
13201312
Style/RedundantArgument:
13211313
Enabled: false
13221314

1323-
<% if rubocop_version >= "1.52" %>
13241315
Style/RedundantArrayConstructor:
13251316
Enabled: false
1326-
<% end %>
13271317

13281318
Style/RedundantAssignment:
13291319
Enabled: false
@@ -1343,10 +1333,8 @@ Style/RedundantConditional:
13431333
Style/RedundantConstantBase:
13441334
Enabled: false
13451335

1346-
<% if rubocop_version >= "1.53" %>
13471336
Style/RedundantCurrentDirectoryInPath:
13481337
Enabled: false
1349-
<% end %>
13501338

13511339
Style/RedundantDoubleSplatHashBraces:
13521340
Enabled: false
@@ -1363,10 +1351,8 @@ Style/RedundantFetchBlock:
13631351
Style/RedundantFileExtensionInRequire:
13641352
Enabled: false
13651353

1366-
<% if rubocop_version >= "1.52" %>
13671354
Style/RedundantFilterChain:
13681355
Enabled: false
1369-
<% end %>
13701356

13711357
Style/RedundantFreeze:
13721358
Enabled: false
@@ -1383,7 +1369,6 @@ Style/RedundantInterpolation:
13831369
Style/RedundantLineContinuation:
13841370
Enabled: false
13851371

1386-
<% if rubocop_version >= "1.53" %>
13871372
Style/RedundantParentheses:
13881373
Enabled: false
13891374

@@ -1392,15 +1377,12 @@ Style/RedundantPercentQ:
13921377

13931378
Style/RedundantRegexpArgument:
13941379
Enabled: false
1395-
<% end %>
13961380

13971381
Style/RedundantRegexpCharacterClass:
13981382
Enabled: false
13991383

1400-
<% if rubocop_version >= "1.52" %>
14011384
Style/RedundantRegexpConstructor:
14021385
Enabled: false
1403-
<% end %>
14041386

14051387
Style/RedundantRegexpEscape:
14061388
Enabled: false
@@ -1436,10 +1418,8 @@ Style/RescueModifier:
14361418
Style/RescueStandardError:
14371419
Enabled: false
14381420

1439-
<% if rubocop_version >= "1.53" %>
14401421
Style/ReturnNilInPredicateMethodDefinition:
14411422
Enabled: false
1442-
<% end %>
14431423

14441424
Style/SafeNavigation:
14451425
Enabled: false
@@ -1462,10 +1442,8 @@ Style/SignalException:
14621442
Style/SingleArgumentDig:
14631443
Enabled: false
14641444

1465-
<% if rubocop_version >= "1.57" %>
14661445
Style/SingleLineDoEndBlock:
14671446
Enabled: false
1468-
<% end %>
14691447

14701448
Style/SingleLineMethods:
14711449
Enabled: false
@@ -1505,10 +1483,8 @@ Style/Strip:
15051483
Style/StructInheritance:
15061484
Enabled: false
15071485

1508-
<% if rubocop_version >= "1.58" %>
15091486
Style/SuperWithArgsParentheses:
15101487
Enabled: false
1511-
<% end %>
15121488

15131489
Style/SwapValues:
15141490
Enabled: false
@@ -1578,10 +1554,8 @@ Style/WordArray:
15781554
Enabled: false
15791555
EnforcedStyle: brackets
15801556

1581-
<% if rubocop_version >= "1.53" %>
15821557
Style/YAMLFileRead:
15831558
Enabled: false
1584-
<% end %>
15851559

15861560
Style/YodaCondition:
15871561
Enabled: false

test/fixtures/full_config.yml

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ AllCops:
8686
- rails
8787
rubocop-rspec:
8888
- rspec
89+
- rspec-rails
8990
rubocop-minitest:
9091
- minitest
9192
rubocop-sequel:
@@ -99,8 +100,6 @@ AllCops:
99100
rubocop-factory_bot:
100101
- factory_bot
101102
- factory_bot_rails
102-
rubocop-rspec_rails:
103-
- rspec-rails
104103
ActiveSupportExtensionsEnabled: false
105104
Bundler/DuplicatedGem:
106105
Description: Checks for duplicate gem entries in Gemfile.
@@ -1167,7 +1166,7 @@ Lint/Debugger:
11671166
Description: Check for debugger calls.
11681167
Enabled: false
11691168
VersionAdded: '0.14'
1170-
VersionChanged: '1.63'
1169+
VersionChanged: '1.46'
11711170
DebuggerMethods:
11721171
Kernel:
11731172
- binding.irb
@@ -1178,14 +1177,8 @@ Lint/Debugger:
11781177
- Kernel.byebug
11791178
- Kernel.remote_byebug
11801179
Capybara:
1181-
- page.save_and_open_page
1182-
- page.save_and_open_screenshot
1183-
- page.save_page
1184-
- page.save_screenshot
11851180
- save_and_open_page
11861181
- save_and_open_screenshot
1187-
- save_page
1188-
- save_screenshot
11891182
debug.rb:
11901183
- binding.b
11911184
- binding.break
@@ -1207,10 +1200,6 @@ Lint/Debugger:
12071200
- jard
12081201
WebConsole:
12091202
- binding.console
1210-
DebuggerRequires:
1211-
debug.rb:
1212-
- debug/open
1213-
- debug/start
12141203
Lint/DeprecatedClassMethods:
12151204
Description: Check for deprecated class method calls.
12161205
Enabled: false
@@ -2082,8 +2071,7 @@ Naming/FileName:
20822071
Enabled: false
20832072
VersionAdded: '0.50'
20842073
VersionChanged: '1.23'
2085-
Exclude:
2086-
- "/Rakefile.rb"
2074+
Exclude: []
20872075
ExpectMatchingDefinition: false
20882076
CheckDefinitionPathHierarchy: true
20892077
CheckDefinitionPathHierarchyRoots:
@@ -3213,13 +3201,6 @@ Style/MapCompactWithConditionalBlock:
32133201
Description: Prefer `select` or `reject` over `map { ... }.compact`.
32143202
Enabled: false
32153203
VersionAdded: '1.30'
3216-
Style/MapIntoArray:
3217-
Description: Checks for usages of `each` with `<<`, `push`, or `append` which can
3218-
be replaced by `map`.
3219-
StyleGuide: "#functional-code"
3220-
Enabled: false
3221-
VersionAdded: '1.63'
3222-
Safe: false
32233204
Style/MapToHash:
32243205
Description: Prefer `to_h` with a block over `map.to_h`.
32253206
Enabled: false

0 commit comments

Comments
 (0)