Merge pull request #628 from Shopify/ko/rescue-more-exceptions

Rescue more exceptions in error handlers

Author: KaanOzkan

lib/ruby_lsp/ruby_lsp_rails/server.rb

@@ -68,8 +68,10 @@ def with_request_error_handling(request_name, &block)
         send_error_response("Request #{request_name} failed because database connection was not established.")
       rescue ActiveRecord::NoDatabaseError
         send_error_response("Request #{request_name} failed because the database does not exist.")
-      rescue => e
-        send_error_response("Request #{request_name} failed:\n#{e.full_message(highlight: false)}")
+      rescue NotImplementedError, LoadError, SyntaxError, SystemExit, SystemStackError => e
+        send_error_response("Request #{request_name} failed with #{e.class}:\n#{e.full_message(highlight: false)}")
+      rescue StandardError => e
+        send_error_response("Request #{request_name} failed with StandardError:\n#{e.full_message(highlight: false)}")
       end
 
       # Handle possible errors for a notification. This should only be used for notifications, which means messages that
@@ -82,8 +84,10 @@ def with_notification_error_handling(notification_name, &block)
         log_message("Request #{notification_name} failed because database connection was not established.")
       rescue ActiveRecord::NoDatabaseError
         log_message("Request #{notification_name} failed because the database does not exist.")
-      rescue => e
-        log_message("Request #{notification_name} failed:\n#{e.full_message(highlight: false)}")
+      rescue NotImplementedError, LoadError, SyntaxError, SystemExit, SystemStackError => e
+        log_message("Request #{notification_name} failed with #{e.class}:\n#{e.full_message(highlight: false)}")
+      rescue StandardError => e
+        log_message("Request #{notification_name} failed with StandardError:\n#{e.full_message(highlight: false)}")
       end
 
       #: (String, String, ?percentage: Integer?, ?message: String?) -> void