From 2b7690fde2c68d975c35ac7e1af6dc2fce2f5f79 Mon Sep 17 00:00:00 2001 From: Alexander Momchilov Date: Wed, 7 May 2025 18:13:26 -0400 Subject: [PATCH 1/2] Improve `Rails::Engine#routes` sig --- rbi/annotations/railties.rbi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rbi/annotations/railties.rbi b/rbi/annotations/railties.rbi index 316f1ced..c0aad763 100644 --- a/rbi/annotations/railties.rbi +++ b/rbi/annotations/railties.rbi @@ -42,7 +42,7 @@ class Rails::Application < ::Rails::Engine end class Rails::Engine < ::Rails::Railtie - sig { params(block: T.untyped).returns(ActionDispatch::Routing::RouteSet) } + sig { params(block: T.nilable(T.proc.bind(ActionDispatch::Routing::Mapper).void)).returns(ActionDispatch::Routing::RouteSet) } def routes(&block); end end From 3f2603a59271063a647da30bae15e0b2a8e37bb5 Mon Sep 17 00:00:00 2001 From: Alexander Momchilov Date: Wed, 7 May 2025 18:44:49 -0400 Subject: [PATCH 2/2] Add sigs for `Rails::Engine.root` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit … and `#root` --- rbi/annotations/railties.rbi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/rbi/annotations/railties.rbi b/rbi/annotations/railties.rbi index c0aad763..5c1e0f0a 100644 --- a/rbi/annotations/railties.rbi +++ b/rbi/annotations/railties.rbi @@ -44,6 +44,14 @@ end class Rails::Engine < ::Rails::Railtie sig { params(block: T.nilable(T.proc.bind(ActionDispatch::Routing::Mapper).void)).returns(ActionDispatch::Routing::RouteSet) } def routes(&block); end + + class << self + sig { returns(Pathname) } + def root; end + end + + sig { returns(Pathname) } + def root; end end class Rails::Railtie