Update Dockerfile to Node 22, remove deprecated @shopify/theme#111
Open
jacobkossman wants to merge 1 commit into
Open
Update Dockerfile to Node 22, remove deprecated @shopify/theme#111jacobkossman wants to merge 1 commit into
jacobkossman wants to merge 1 commit into
Conversation
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Dockerfile currently uses
node:20-bookworm, which limits@shopify/clito the 3.x branch (4.x requires Node >=22.12.0). This causesshopify theme pushto fail when block or section schemas usecolor_palettedynamic defaults (e.g.{{ settings.colors.foreground }}).This was fixed in
@shopify/cli4.0.0 — specifically 1e8963e, which uploadsconfig/settings_schema.jsonbefore any other theme file so that blocks/sections referencingcolor_palettesettings resolve correctly on first push. However, 4.0.0 also dropped Node 20 support (0c35553), so the fix is unreachable from a Node 20 base image.Changes
FROM node:20-bookworm→FROM node:22-bookworm@shopify/themefromnpm install -g(deprecated since CLI 3.59.0, now bundled in@shopify/cli)