Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**suggestion:** Make the video limit configurable instead of hardcoding #51

Open
Shloimy15e opened this issue Aug 20, 2024 · 0 comments
Assignees

Comments

@Shloimy15e
Copy link
Owner

          **suggestion:** Make the video limit configurable instead of hardcoding

Consider making the limit parameter configurable or consistent with limits used elsewhere in the application. This would provide more flexibility and maintainability.

const DEFAULT_LIMIT = 6;

const fetchVideos = async (subtopic: string, limit: number = DEFAULT_LIMIT): Promise<Video[]> => {
  const response = await fetch(`/api/videos/?subtopic__name__iexact=${subtopic}&limit=${limit}`);
  const data = await response.json();
  return data.results;
};

Originally posted by @sourcery-ai[bot] in #30 (comment)

@Shloimy15e Shloimy15e self-assigned this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant