-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not most recent version of LedFx? #20
Comments
Would be awesome to have the newest version, indeed, but it seems @ShiromMakkad hasn't been here in a while, which is unfortunate. |
I tried running the update script but it failed. I won't have time to dig into it for a little bit. |
I updated the Dockerfile a while ago, it worked at least for me like this:
I added these three lines:
|
How'd you get that line for CFlags? I just checked and it's the aubio compilation that's failing. You shouldn't need to add the extra pip install for that or numpy because they should be dependencies. Honestly though, updating aubio separately so it makes a different layer in Docker may be worth it just because of how long it takes to compile. |
Would be really awesome if we got an update. I really love this image but I'm not skilled enough to figure it out myself. It's alright if you don't have the time though. |
Yea, I haven't had LEDs up for a while. Unfortunately, it's just low on my list right now. I do plan to put them up at some point and start developing on this repo, but for now I can't really respond to issues. There are a lot of really interesting issues with advice open that I do want to look at. I would review a PR though. Updating LedFx should be a pretty gentle introduction to Docker. Most of the work was on the audio rather than building LedFx, but it takes an annoyingly long time to test because of the compilation times for ARM which I don't have right now. |
Been fiddling around for a few weeks and managed to get it to build by changing the base image to a more recent version of python (python:3.10.14-bullseye), and installing cmake and numpy. This dockerfile works for me...
|
It seems like the docker container does not contain the current version of LedFx. It would be great if you could update it.
Thanks in advance.
The text was updated successfully, but these errors were encountered: