add errors

Author: silesky

lib/shipengine/client/platform.rb

@@ -16,13 +16,13 @@ def initialize(api_key:, base_url: 'https://simengine.herokuapp.com/jsonrpc', ad
     end
 
     def assert_no_platform_errors(response)
-      puts response.inspect
-      status = response.status
-      error = response.body['error'] || {}
-      status == 400 and
-        raise ShipEngine::Exceptions::ValidationError, error['message'] || status.to_s
-      status >= 401 and
-        raise ShipEngine::Exceptions::ShipEngineError, error['message'] || status.to_s
+      # puts response.inspect
+      body = response.body
+      error = body['error'] || {}
+      data = error['data']
+      return unless data
+        raise ShipEngine::Exceptions::ShipEngineErrorDetailed.new(body['id'], error['message'], data) unless data.nil?
+      end
     end
 
     # create jsonrpc request has

lib/shipengine/exceptions.rb

@@ -1,6 +1,7 @@
 module ShipEngine
   module Exceptions
     #  standard class - network connection error / internal server error /etc
+
     class ShipEngineError < StandardError
       def initialize(message_or_messages)
         message = message_or_messages.is_a?(Array) ? message_or_messages.join('\n') : message_or_messages
@@ -9,7 +10,14 @@ def initialize(message_or_messages)
     end
 
     # 400 error, or other "user exceptions"
-    class ValidationError < ShipEngineError
+    class ShipEngineErrorDetailed < ShipEngineError
+      def initialize(request_id, message, data)
+        super(message)
+        @request_id = request_id
+        @source = data['source']
+        @type = data['type']
+        @code = data['code']
+      end
     end
   end
 end

test/client_test.rb

@@ -1,5 +1,5 @@
 require 'test_helper'
-
+require 'pry'
 describe 'Client test' do
   it 'Should make a request' do
     client = ::ShipEngine::PlatformClient.new(api_key: 'abc123')
@@ -13,4 +13,14 @@
     success_request = client.make_request('address/validate', params)
     assert success_request
   end
+
+  it 'Should throw Errors' do
+    client = ::ShipEngine::PlatformClient.new(api_key: 'abc123')
+    client.make_request('address/validate', { foo: 'invalid request' })
+    raise 'should not happen'
+  rescue ShipEngine::Exceptions::ShipEngineError => e
+    assert e.message.is_a?(String)
+  else
+    raise 'should not happen'
+  end
 end