ISSUE-20: Print full path from no-boms

Author: AFulgens

hooks/no_boms.py

@@ -2,7 +2,6 @@
 
 import argparse
 from collections.abc import Sequence
-from os.path import basename
 
 
 def main(argv: Sequence[str] | None = None) -> int:
@@ -21,19 +20,19 @@ def main(argv: Sequence[str] | None = None) -> int:
         # Cf. https://www.unicode.org/faq/utf_bom.html#BOM
         if candidate == b'\xff\xfe\x00\x00':
             result *= 13
-            print(f'{basename(filename)}: has a UTF-32 BOM (LE)')
+            print(f'{filename}: has a UTF-32 BOM (LE)')
         elif candidate == b'\x00\x00\xfe\xff':
             result *= 11
-            print(f'{basename(filename)}: has a UTF-32 BOM (BE)')
+            print(f'{filename}: has a UTF-32 BOM (BE)')
         elif candidate[:2] == b'\xff\xfe':
             result *= 7
-            print(f'{basename(filename)}: has a UTF-16 BOM (LE)')
+            print(f'{filename}: has a UTF-16 BOM (LE)')
         elif candidate[:2] == b'\xfe\xff':
             result *= 5
-            print(f'{basename(filename)}: has a UTF-16 BOM (BE)')
+            print(f'{filename}: has a UTF-16 BOM (BE)')
         elif candidate[:3] == b'\xef\xbb\xbf':
             result *= 3
-            print(f'{basename(filename)}: has a UTF-8 BOM')
+            print(f'{filename}: has a UTF-8 BOM')
 
     return result % 256 if result != 1 else 0
 

tests/test_no_boms.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import re
 import unittest
 from pathlib import Path
 from unittest.mock import call
@@ -20,8 +21,8 @@ def test_utf32_bom_le(tmpdir):
             b'\x86\x98\xe3\x86\x92\xe3\x86\x9d',
         )
         assert no_boms.main((str(f),)) == 13
-        assert call('bom32le.txt: has a UTF-32 BOM (LE)') \
-               in mocked_print.mock_calls
+        assert re.match(r'^.*[\\/]bom32le\.txt: has a UTF-32 BOM \(LE\)$',
+                        mocked_print.call_args.args[0]) is not None
 
 
 def test_utf32_bom_be(tmpdir):
@@ -37,8 +38,8 @@ def test_utf32_bom_be(tmpdir):
             b'\x86\x98\xe3\x86\x92\xe3\x86\x9d',
         )
         assert no_boms.main((str(f),)) == 11
-        assert call('bom32be.txt: has a UTF-32 BOM (BE)') \
-               in mocked_print.mock_calls
+        assert re.match(r'^.*[\\/]bom32be\.txt: has a UTF-32 BOM \(BE\)$',
+                        mocked_print.call_args.args[0]) is not None
 
 
 def test_utf16_bom_le(tmpdir):
@@ -54,8 +55,8 @@ def test_utf16_bom_le(tmpdir):
             b'\x86\x98\xe3\x86\x92\xe3\x86\x9d',
         )
         assert no_boms.main((str(f),)) == 7
-        assert call('bom16le.txt: has a UTF-16 BOM (LE)') \
-               in mocked_print.mock_calls
+        assert re.match(r'^.*[\\/]bom16le\.txt: has a UTF-16 BOM \(LE\)$',
+                        mocked_print.call_args.args[0]) is not None
 
 
 def test_utf16_bom_be(tmpdir):
@@ -71,8 +72,8 @@ def test_utf16_bom_be(tmpdir):
             b'\x86\x98\xe3\x86\x92\xe3\x86\x9d',
         )
         assert no_boms.main((str(f),)) == 5
-        assert call('bom16be.txt: has a UTF-16 BOM (BE)') \
-               in mocked_print.mock_calls
+        assert re.match(r'^.*[\\/]bom16be\.txt: has a UTF-16 BOM \(BE\)$',
+                        mocked_print.call_args.args[0]) is not None
 
 
 def test_utf8_bom_directly(tmpdir):
@@ -88,8 +89,8 @@ def test_utf8_bom_directly(tmpdir):
             b'\x86\x98\xe3\x86\x92\xe3\x86\x9d',
         )
         assert no_boms.main((str(f),)) == 3
-        assert call('bom8.txt: has a UTF-8 BOM') \
-               in mocked_print.mock_calls
+        assert re.match(r'^.*[\\/]bom8\.txt: has a UTF-8 BOM$',
+                        mocked_print.call_args.args[0]) is not None
 
 
 def test_utf8_bom_via_encoding(tmpdir):