From bdf8d79aff22282b4657f753a485fb54631bd8ab Mon Sep 17 00:00:00 2001 From: dreirund <1590519+dreirund@users.noreply.github.com> Date: Mon, 9 Mar 2026 14:14:58 +0100 Subject: [PATCH] Remove "Fast react when temperature is cooling" comment in "Unthrottle if cool" part in the main loop, as well as additional 0.5s waiting. In issue https://github.com/Sepero/temp-throttle/issues/55 it is described that there is a conflict between behaviour and comment in the main loop in the "Unthrottle if cool" part: * The comment says "Fast react when temperature is cooling", but the behaviour is that there is a waiting time of 0.5s + `$INTERVAL`. * This is a suggestion to fix this discrepancy by removing the misleading comment "Fast react when temperature is cooling" comment in "Unthrottle if cool", as well as the additional `sleep 0.5`. It adds another explanatory comment. Closes https://github.com/Sepero/temp-throttle/issues/55. Mutually exclusive with pull request https://github.com/Sepero/temp-throttle/pull/56, which solves the same discrepancy by actually activating fast reaction in this code path. --- usr/sbin/temp-throttle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr/sbin/temp-throttle b/usr/sbin/temp-throttle index ae1225c..3aa06fc 100755 --- a/usr/sbin/temp-throttle +++ b/usr/sbin/temp-throttle @@ -3,7 +3,7 @@ # Usage: temp-throttle # No arguments will default read from /etc/temp-throttle.conf # Usage: temp-throttle [-t MAX_TEMP] [-c CONFIG_FILE] [-k CORE] [-f TEMP_FILE] [-i INTERVAL] [-l LOG_FILE] -VERSION="3.02" +VERSION="3.03" cat << EOF Author: Sepero 2012- sepero 111 @ gmx . com @@ -219,7 +219,7 @@ while true; do elif [[ $TEMP -le $LOW_TEMP && $CURRENT_FREQ -ne 1 ]]; then # Unthrottle if cool. unthrottle - sleep 0.5 # Fast react when temperature cooling. + # Do not fast react when temperature cooling; just wait `$INTERVAL`. fi # Sleep wait between checking temperatures. sleep $INTERVAL || err_exit "Sleep wait INTERVAL must be an integer or float value: $INTERVAL"