Move settings directory from /data/data to internal storage
An optional setting should select /data/data, internal storage  or app specific directory /storage/emulated/0/android/data/app_tag

After app reinstall or a new request to storage permissions, previous messages were not properly loaded and could be overwritten

Some labels had a wrong description

jcifs 1.3 library is recompiled with jcifs13 class and we keep the upstream jcifs-ng class to jcifs.
This makes it possible to directly update the jcifs lib to the latest release by just swapping the library instead of recompiling jcifs-ng with a custom class

JcifsFile2 is upgraded to support the new jcifs libs

Utilities3 is upgraded to use updated wrapperForSlf4j that supports latest logging formats by slf4j and that are needed by jcifs-ng and any future external lib relying on slf4j logger

- fix SMB sync was broken when a custom port was set in destination
- fix SMB sync error message displaying url:port:port error instead of url:port

- When editing an SMB server with a user/password set, the user/pass were empty and editing the server details caused the user/pass to be lost

Allow copy/paste in unhidden password field when importing an encrypted app settings file

…tings

allow password confirmation field toggle and copy/paste when exporting settings with password

- Zip password: fix confirmation password view always disabled and a zip password could not be set
- Zip password: enable password show/hide icon with confirmation password field toggle
- Zip password: preserve password visibility view state on screen rotation

Properly toggle SMB password TextInputLayout view on use password check/uncheck (no functional changes, but for code clarity)

When option "Edit SMB Server Parameters" is unchecked, mask the SMB server password

On screen rotation, ensure SMB password cannot be shown if Edit SMB Server parameters option is unchecked
Not needed because the check is also done later in setSyncFolderSmbListener: if the Edit SMB Server parameters option is unchecked, the ll_sync_folder_pswd_view is disabled and password is automatically masked

After screen rotation in SMB and ZIP, properly enable/disable Save button on view changes

- fix bug where the following spinners were disabled after screen rotation:
  + Sync Task Type spinner
  + Sync Wifi option spinner
  + DST offset spinner
- remove orphan code

…aved

In SMB server, if the option "Use account name and password" is unchecked, do not discard the current user/pass on screen rotation until user clicks "Save" button in SMB edit view

If settingSecurityReinitSmbAccountPasswordValue is set, the option Use SMB account/password could be wrongly checked

In Zip edit dialog, if the option "Encryption method" is set to "None", do not discard the current Zip password on screen rotation until user clicks "Save" button in ZIP edit view

New option:  Settings / Security / App settings directory

- upgrade Utilities3 to use last upstream zip4j version 2.11.1
- build is now possible using stock upstream zip4j

- fix SyncTask, History and messages could no longer be properly selected after screen rotation
- if selection mode was enabled in SyncTask, History or messages, after screen rotation the view was unresponsive

This was caused by the corresponding adapters being initialized too early on reloadscreen() view and before the adapter list is populated

When creating a Zip Sync Task, when we browse for existing files and we enter a zip file name, browsing further into an empty directory disabled the Ok button even if the filename is properly set

When editing/creating a zip sync task, if user sets a file name, keep it when browsing for location or a new zip file

Temporary fix instead of creating an activity fragment for the dialog in TaskListUtils

While in SMB Scanner to select an SMB server after scan, if screen is rotated, after clicking Save button, the selected server settings were not reflected. This fixes the issue

- remove unused variables
- pass in smb settings variables instead of dialog to invokeSelectSmbShareDlg()

- Fix SMB scanner search results and selected host views
- Move ListView out of ScrollView
- Add a ScrollView to Results scanner so that results are not pushed outside screen
- Fix margins

- Scan results: always show the "Search results:" message
- Always show scroll bar when needed in Scan settings and Server settings Scroll Views
- Always show scroll bar when needed in Scan results and Server shares List Views

- SMB scanner:
  + fix scan progress formatting %s to %d
  + enable user choice to select scanning library SMBv1 (jcifs 1.3.19) or SMBv2/3 (jcifs-ng)
  + by default, intial scan will use the SMB library set in currently configured server or the default app SMB level
  + add option to make initial scan using a custom port (not used)
  + first scan will still use both 139 and 445 default ports
  + UI enhancements
  + use global SMB level labels
- Add index constants for global smb level spinner

- Fix server scanner results alignment when the server has no detected host name

After a first smb scan, when it is completed or cancelled, the next scans started from the same dialog permit to select a server from displayed results while the scan is running.
This caused the scan to continue running in the background until it was completed. Further scans could be even started while the first scan was not completed causing a significant network hammering.
Now, the scan results can no longer be selected until a scan thread is cancelled or completed

In SMB scanner, when selecting an SMB server from search results, properly update the dialog error message.
If user, password, port or SMB level settings are changed within the server settings, the shares list is cleared and user must refresh again the shares

Modify UI function selectRemoteShareDlg() to return the whole list of shares

After a scan, when selecting a server from scan results, the selected server settings will reflect the port that could successfully connect to the server during scan
Previously, it showed an empty port, thus defaulting back to 139 and 445 ports

Previously, the port was ignored and always defaulting to 139 as first port

- SMB scanner: When refreshing shares, properly set error message if port / SMB protocol were changed and connection fails.
This is not yet properly working because "Refresh Shares" uses a delayed thread and the connection will wait to timeout for 30 sec in SMB level 2/3

- On refresh shares, only check the currently selected SMB protocol and not both protocols

On selected SMB server from scan results, when we click refresh shares, an animation will show and properly wait for the SMB server connection to complete or timeout
Previously, a connection thread could keep running in the background without any connection error message displayed if server went down or connection settings changes

- implement spinner instead of radio buttons to select SMB level to scan for
- when an SMB level is selected, detect only the selected protocol
- by default, scan for both SMB v1 and SMB v2/3 enabled servers
- when a server is selected, disable the SMB level radio button for the protocol that was not found to be enabled during scan
- if we select a server that had no enabled SMB level protocol during scan, warn and force a new scan
Refreshing shares is no longer possible in this case: exp, when search for SMBv1 servers, SMBv2 only servers could be selected

During scan, if we select SMBv1 protocol, disable selection of servers with only SMBv2 protocol, and inversely if we select SMBv2/3 protocol for scan
- Complete resources in xml/translation

On selected server from scanner results, if password is toggled to show/hide, do not clear a currently displayed shares list

- Use ConstraintLayout to adjust screen elements for the spinner. For long languages, spinner or label can no longer be collapsed totally. Screen layout is better than using weighted layout or layout_constraintWidth_percent
- Fix left margin for port number field was too large

- If view height is narrow (landscape, very small devices), fix the scroll view taking up all the space of scanner results list view.
- add error/hint top red message to the scroll view to better fit the scan results ListView  on narrow height orientations/screens
- Use new androidx.constraintLayout
- pull the scan results listview outside of the ScrollView: fixes the Listview collapsing to a single element or the ListView not being scrollable if it includes many elements

Fix scan results without either SMB v1 neither SMB v2/3 could still be selected and were not shown as greyed out (disabled)
This could happen when scanning on unsupported server ports

If many scan results are available in a short interval, the results list adapter could be modified in a non synchronized way by different threads, same for the results ListView
This can be reproduced by enabling the // debug code in commit to quickly add all ip range servers to the adapter

Ensure the Scan results view is enabled only after the ongoing scan threads are completed. This fixes the issue where once scan is cancelled, the GUI got enabled too quickly and some scan results could show only after a few seconds/minutes in the results view

Server selection dialog from SMB Scanner results: fixes for small screens

On app start and editing SyncTask directories, an NPE crash occurs when trying to get App Specific Directory
The method result was not used actually as the paths are currently hard coded in Utilities3, so the crash was not happening on all systems and every time

Do not use hard coded references like "/storage/emulated/0". Use built in Android methods to get relevant storage path. This ensures a better compatibility across devices with different storage path standard

SNB Scanner:
- it is now truely multithreading
- simpler code and limit nested synchronizer blocks
- fix compiler warnings and synchronize on true final objects

On SMB Scanner server result selected dialog, we use a scroll view and a listview below it.
To properly let the user know that the info message (in red is present):
- if error message is out of screen, change dialog title color to red
- on refresh shares, if error, always scroll to top of screen and show the error
- various code optimization to select/unselect listview items

- SMB Scanner: fix changing hidden password did not reset a displayed shares list unless end eye icon was first pressed. After it was pressed once, it worked as expected
- Change scroll to top and set title color methods to generic parameters

On SMB Scanner dialog, we use a scroll view and a listview below it to display scan results.
To properly let the user know that the info message (in red is present):
- if error message is out of screen, change dialog title color to red
- after a scan for servers, always scroll to top of screen and show the result message

Use new APIs to set font size. This requires now an optional app restart like theme and language

On language, theme, font or app dir changes, an app restart is either optional or required
Cleanup the code to make it clear how the checks are processed after settings change
Also, localize some variables in the various Settings activity subclasses

- replace deprecated onAttach(Activity a) by onAttach(Context c)

The archived file name preview text during Edit Archive Sync Task

Just to have a proper implementation of the SyncFolderEditValue class and be able to clone it using both methods