Repository navigation
[NVIDIA][AgentX] Tune GLM-5.2 FP8 B300 SGLang MTP recipes and extend grid to c28 / [NVIDIA][AgentX] 调优 GLM-5.2 FP8 B300 SGLang MTP 配方并将并发扩展至 c28 - #3836
Conversation
|
Thanks for the contribution!
中文感谢你的贡献!
|
There was a problem hiding this comment.
Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.
Beyond the inline pr-link finding, I also looked at the per-concurrency max-running-requests drop (e.g. c4: 8→3, c12: 24→5, c16: 32→7, now below CONC) and the varying speculative-num-steps/draft-tokens per point — these appear to be intentional MTP/admission tuning rather than bugs, so I'm not flagging them separately.
Extended reasoning...
Config-only change to a single GLM-5.2 FP8 B300 SGLang recipe plus matching master config and an appended perf-changelog entry; no auth/crypto/permission surface. One confirmed issue (placeholder pr-link of pull/0) is already posted inline. I additionally reviewed the max-running-requests-below-concurrency and per-point speculative-decoding depth changes noted as candidates and found them consistent with intentional tuning, not separate bugs worth inline comments.
| description: | ||
| - "Tune GLM-5.2 FP8 B300 SGLang MTP depth, admission caps, and HiCache scheduling per concurrency." | ||
| - "Pin the SGLang image by digest." | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/0 |
There was a problem hiding this comment.
🟡 (optional) The new perf-changelog entry's pr-link is https://github.com/SemiAnalysisAI/InferenceX/pull/0, which looks like an unfilled placeholder rather than the real PR number, unlike every prior entry (e.g. pull/3603 immediately above). If merged as-is, maintainers tracing this performance change back to its review discussion get a dead/wrong link instead of the actual PR. Fix: replace pull/0 with the actual PR number before merge.
Why this was flagged
inferencex-e2e/perf-changelog.yaml:9421 sets pr-link to pull/0 for the newly appended glm5.2-fp8-b300-sglang-agentic-mtp entry, while the file's established convention (seen at line 9410, pull/3603) is one real PR link per block. pull/0 does not correspond to any real PR in SemiAnalysisAI/InferenceX. Anyone auditing this perf change via the changelog's pr-link, as the append-only changelog is meant to support, gets a broken/placeholder reference instead of the review history.
Verification: nit. The new appended block at inferencex-e2e/perf-changelog.yaml:9414-9421 ends with pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/0 (line 9421). Every other block uses a real PR number — the immediately preceding block ends .../pull/3603 (line 9412). pull/0 is not a valid GitHub PR number and is clearly an unfilled placeholder, so anyone tracing this perf change back via the changelog's pr-link gets a dead/placeholder reference instead of the actual PR.
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=38304664439 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=38304664439 |
|
[by Claude Code] The SGLang cookbook integration of this PR's AgentX config ( |
|
[by Claude Code] sgl-project/sglang#43083 has been merged. This PR's AgentX config ( This PR has no authorized |
|
@nvpohanh staged run 37815475708: https://inferencemax-app-git-staging-semianalysisai.vercel.app/inference?i_dates=2026-10-08~r37815475708 This run remains available across future |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have:
Additional detail section:
Signed: |
✅✅✅ Verdict: PASS ✅✅✅Passed and not applicable checks✅ Check 0 (CODEOWNER): PASS — ✅ Check 1 (Passing sweep on in-PR commit): PASS — PR's only commit ✅ Check 2 (Evals): PASS — ✅ Check 3 (Upstream recipe): PASS — sgl-project/sglang#43983 MERGED 2026-10-13T06:39Z (refreshing #43083, MERGED 2026-10-09). ✅ Check 4 (Reuse command): PASS — ✅ Check 5 (Latest checklist): PASS — all 17 current-template items, including the sub-item, are present and checked. ✅ Check 6 (Upstream image / ordering): PASS — ✅ Check 7 (Deprecated models): PASS — ✅ Check 8 (No architecture hacks): PASS — the recipe at the pinned SHA has no ✅ Check 9 (Chat template for spec decode): PASS — AgentX replay drives the chat endpoint; the C28 server metrics are keyed ✅ Check 10 (No engine patches): PASS — the change is config-only (recipe, master config, changelog); no scripts, patches, ✅ Check 11 (Agentic golden AL): PASS — the job logs set ➖ Check 12 (Append-only): N/A — the new changelog entry does not set ✅ Check 13 (Draft as shipped): PASS — the draft is the checkpoint's built-in NextN layer ( ✅ Check 14 (Pareto coverage): PASS — one curve, ✅ Check 15 (PR description): PASS — the body's per-concurrency MTP/admission tuning, digest-pinned image, and c20/c24/c28 extension at 2x-CONC admission match the pinned recipe and master config. ✅ Check 16 (NVIDIA overview): PASS — the NVIDIA overview Framework Recipes table lists GLM-5.2 with SGLang ✅, linking to the GLM-5.2 cookbook page (B300). Assessed commit: |
…grid to c28 / [NVIDIA][AgentX] 调优 GLM-5.2 FP8 B300 SGLang MTP 配方并将并发扩展至 c28 Tune MTP depth, admission caps and HiCache scheduling with one recipe per concurrency (c1 K6/cap2, c4 K4/cap3, c8 unchanged, c12 K5/cap5, c16 K4/cap7 with prefill-decode-interval 8 and write_through), pin the upstream SGLang image by digest, and add c20, c24 and c28 with uncapped admission (2x CONC). 按并发调优 MTP 深度、准入上限和 HiCache 调度,每个并发一个配方;按摘要固定 上游 SGLang 镜像;新增 c20、c24、c28(不限制准入,2x CONC)。 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
03ffb35 to
3120bc1
Compare
|
[by Claude Code] The SGLang cookbook update of this PR's AgentX config ( This PR has no authorized |
|
[by Claude Code] sgl-project/sglang#43983 has been merged. This PR's AgentX config ( This PR has no authorized |
|
/use 38304664439 |
|
@nvpohanh staged run 38304664439. This run remains available across future |
Summary
Config-only update to
glm5.2-fp8-b300-sglang-agentic-mtp: per-concurrency MTP depth and admission tuning, image pinned by digest, and the grid extended to c20, c24 and c28 (uncapped admission).AI model disclosure
claude-sonnet-5-5(Claude Sonnet 5.5): prepared the config change and PR text.