Skip to content

Commit d265460

Browse files
add to ai reviewer to explicitly check for disabling server metrics / 签核明确禁止禁用事件和指标发布
* fix: ban disabled event and metric publication in signoff review 在签核审阅中明确禁止禁用事件和指标发布,并同步中英文审阅清单。 * fix: keep publication ban in reviewer prompt only 撤回中英文审阅清单修改,仅保留审阅提示词中的禁用规则。
1 parent e308c4a commit d265460

1 file changed

Lines changed: 22 additions & 1 deletion

File tree

‎.github/codeowner-signoff-verify-prompt.md‎

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,28 @@ production by accuracy-sensitive customers.
272272
present, determine whether the override changes computed FLOPs vs the model's native
273273
config and whether the model natively supports that mode.
274274
- FAIL with the exact flag/value if architecture FLOPs are reduced without native
275-
model support. PASS in one line otherwise. Use N/A if the PR touches no server args.
275+
model support.
276+
277+
EXPLICIT PROHIBITION: `publish_events_and_metrics: false` is not allowed.
278+
FAIL Check 8 if an affected benchmark's effective serving configuration disables
279+
`publish_events_and_metrics`, including equivalent false values recognized by the
280+
pinned implementation in YAML/JSON, CLI overrides, inherited configuration, shared
281+
launchers/helpers, or container/image defaults. Apply this to added, modified, and
282+
re-enabled benchmarks, including image-only bumps, across agentic/non-agentic and
283+
single-node/multi-node paths. Inspect the effective recipe at the PINNED head SHA,
284+
including unchanged referenced files; do not limit review to added diff lines.
285+
- Where the setting is supported, verify that it is enabled. An omitted setting
286+
is compliant only when the pinned implementation confirms its effective default
287+
is enabled. If the effective value cannot be verified, FAIL as
288+
"Event/metric publication could not be verified", naming the missing evidence.
289+
- Report the affected config/script, the disabling value, and where it comes from.
290+
Require enabling publication and verifying the effective setting. Passing evals,
291+
an upstream recipe, or historical runs do not exempt the prohibition.
292+
- Comments, documentation examples, and removed diff lines are not runtime
293+
disablement. A framework that does not support this setting need not add it.
294+
- PASS Check 8 only when both the architecture rule and this prohibition are
295+
satisfied. Use N/A only if the PR affects no benchmark serving configuration,
296+
image, or launch path.
276297

277298
## Check 9 — Speculative-decoding configs benchmark through chat templates
278299
If this PR adds or changes a speculative-decoding config (MTP / EAGLE / draft-model

0 commit comments

Comments
 (0)