Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a version range for cfn-lint #188

Open
ankon opened this issue Jun 1, 2022 · 0 comments
Open

Specify a version range for cfn-lint #188

ankon opened this issue Jun 1, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest https://hacktoberfest.com/participation/ help wanted Extra attention is needed javascript Pull requests that update Javascript code

Comments

@ankon
Copy link

ankon commented Jun 1, 2022

Is your feature request related to a problem? Please describe.

We're creating SARIF output with cfn-lint, and that was broken in some case until their 0.61 release. We had a workaround in place though, so all is good. Now that cfn-lint is fixed though I want to remove the workaround, and instead looked for a way to say "please use cfn-lint >= 0.61" for this action.

I found that there is a version input, but it takes an explicit version, and not a range:

`cfn-lint==${version}`,

Describe the solution you'd like

Allow to specify a "version specifier" (https://peps.python.org/pep-0440/#version-specifiers), so that I could say version: >=0.61.

Describe alternatives you've considered

  1. Using a fixed version (version: 0.61): This is problematic, because cfn-lint obviously moves a lot, and I would now have to track the versions and update my action configuration. This is "manual work" (no dependabot to help, for instance), and produces churn in my repository.
  2. "YOLO": Just remove the workaround, the action will update from the code: This probably works, but I feel uncomfortable with it in terms of documenting the intents.
@ankon ankon added the enhancement New feature or request label Jun 1, 2022
@ScottBrenner ScottBrenner added good first issue Good for newcomers help wanted Extra attention is needed javascript Pull requests that update Javascript code labels Jun 2, 2022
@ScottBrenner ScottBrenner added the hacktoberfest https://hacktoberfest.com/participation/ label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest https://hacktoberfest.com/participation/ help wanted Extra attention is needed javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

2 participants