Skip to content

Missing dependencies in .pre-commit-hooks.yaml #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dementive opened this issue Aug 16, 2024 · 0 comments · May be fixed by #369
Open

Missing dependencies in .pre-commit-hooks.yaml #317

dementive opened this issue Aug 16, 2024 · 0 comments · May be fixed by #369
Labels
bug Something isn't working

Comments

@dementive
Copy link

To run the linter or formatter with a pre-commit hook the setuptools library has to be installed into the pre-commit library. Currently the .pre-commit-hooks.yaml does not do this, updating it to this will fix it:

- id: gdlint
  name: gdlint
  description: "gdlint - linter for GDScript"
  entry: gdlint
  language: python
  language_version: python3
  additional_dependencies: [setuptools]
  require_serial: true
  types: [gdscript]
- id: gdformat
  name: gdformat
  description: "gdformat - formatter for GDScript"
  entry: gdformat
  language: python
  language_version: python3
  additional_dependencies: [setuptools]
  require_serial: true
  types: [gdscript]
@Scony Scony added the bug Something isn't working label Aug 18, 2024
@Person-93 Person-93 linked a pull request Apr 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add setuptools dependency in pre-commit hook Person-93/godot-gdscript-toolkit
2 participants
@Scony @dementive