Skip to content

Made some changes in relation to the first PyTest conversion sprint #6548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ESadek-MO
Copy link
Contributor

🚀 Pull Request

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@trexfeathers trexfeathers self-assigned this Jul 7, 2025
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (1ef8c4c) to head (5a65927).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6548   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files          90       90           
  Lines       24138    24138           
  Branches     4492     4492           
=======================================
  Hits        21699    21699           
  Misses       1679     1679           
  Partials      760      760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ESadek-MO. One small change is necessary

@@ -73,4 +74,6 @@ Common Translations
- ``with pytest.raises(cls, match=msg_re):``
* - ``mock.patch(...)``
- ``mocker.patch(...)``
* - ``with mocker.patch.object(...) as x:``
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* - ``with mocker.patch.object(...) as x:``
* - ``with mock.patch.object(...) as x:``

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that either syntax is OK, and that it would be less confusing to stick with mocker everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants