-
Notifications
You must be signed in to change notification settings - Fork 296
Made some changes in relation to the first PyTest conversion sprint #6548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6548 +/- ##
=======================================
Coverage 89.89% 89.89%
=======================================
Files 90 90
Lines 24138 24138
Branches 4492 4492
=======================================
Hits 21699 21699
Misses 1679 1679
Partials 760 760 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ESadek-MO. One small change is necessary
@@ -73,4 +74,6 @@ Common Translations | |||
- ``with pytest.raises(cls, match=msg_re):`` | |||
* - ``mock.patch(...)`` | |||
- ``mocker.patch(...)`` | |||
* - ``with mocker.patch.object(...) as x:`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* - ``with mocker.patch.object(...) as x:`` | |
* - ``with mock.patch.object(...) as x:`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that either syntax is OK, and that it would be less confusing to stick with mocker
everywhere.
🚀 Pull Request
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: