Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exceptions instead of using assert #366

Open
bouweandela opened this issue Jun 11, 2024 · 3 comments
Open

Raise exceptions instead of using assert #366

bouweandela opened this issue Jun 11, 2024 · 3 comments

Comments

@bouweandela
Copy link
Member

There are assert statements in various places, e.g.
https://github.com/SciTools-incubator/iris-esmf-regrid/blob/fdd2051dfff050b18c356a2b4277426e74415a61/esmf_regrid/schemes.py#L185-L186

For applications and users of this library, it would be nice to replace those with exceptions with a message explaining the error.

@trexfeathers
Copy link
Contributor

Copy link
Contributor

@SciTools/esmf-regrid-devs This issue is stale due to a lack of activity in the last 180 days. Remove stale label or comment, otherwise this issue will close automatically in 14 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Dec 10, 2024
@stephenworsley
Copy link
Contributor

Now captured by #437. (Ruff S101)

@github-actions github-actions bot removed the Stale: Closure warning This stale issue or pull-request has been marked for closure label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants