Fix SqliteService table creation

Author: Oceania2018

src/Infrastructure/BotSharp.Abstraction/Agents/Models/Agent.cs

@@ -1,9 +1,11 @@
 using BotSharp.Abstraction.Functions.Models;
 using BotSharp.Abstraction.Plugins.Models;
 using BotSharp.Abstraction.Tasks.Models;
+using System.Diagnostics;
 
 namespace BotSharp.Abstraction.Agents.Models;
 
+[DebuggerStepThrough]
 public class Agent
 {
     public string Id { get; set; } = string.Empty;

src/Infrastructure/BotSharp.Core/Instructs/Services/InstructService.Execute.cs

@@ -336,7 +336,8 @@ private async Task<string> GetChatCompletion(
         {
             Id = agent.Id,
             Name = agent.Name,
-            Instruction = instruction
+            Instruction = instruction,
+            LlmConfig = agent.LlmConfig
         }, new List<RoleDialogModel>
         {
             new RoleDialogModel(AgentRole.User, text)

src/Infrastructure/BotSharp.Core/data/agents/01fcc3e5-0af7-49e6-ad7a-a760bd12dc4d/agent.json

@@ -9,7 +9,7 @@
   "isPublic": true,
   "llmConfig": {
     "provider": "openai",
-    "model": "gpt-4o-mini"
+    "model": "gpt-5-mini"
   },
   "profiles": [ "fallback" ]
 }

src/Plugins/BotSharp.Plugin.ExcelHandler/Functions/ReadExcelFn.cs

@@ -146,26 +146,14 @@ private List<SqlContextOut> GetResponeFromDialogs(List<RoleDialogModel> dialogs)
     private string GenerateSqlExecutionSummary(List<SqlContextOut> results)
     {
         var stringBuilder = new StringBuilder();
-        if (results.Any(x => x.isSuccessful))
-        {
-            stringBuilder.Append("---Success---");
-            stringBuilder.Append("\r\n");
-            foreach (var result in results.Where(x => x.isSuccessful))
-            {
-                stringBuilder.Append(result.Message);
-                stringBuilder.Append("\r\n\r\n");
-            }
-        }
-        if (results.Any(x => !x.isSuccessful))
+
+        stringBuilder.Append("\r\n");
+        foreach (var result in results)
         {
-            stringBuilder.Append("---Failed---");
-            stringBuilder.Append("\r\n");
-            foreach (var result in results.Where(x => !x.isSuccessful))
-            {
-                stringBuilder.Append(result.Message);
-                stringBuilder.Append("\r\n");
-            }
+            stringBuilder.Append(result.Message);
+            stringBuilder.Append("\r\n\r\n");
         }
+
         return stringBuilder.ToString();
     }
 

src/Plugins/BotSharp.Plugin.ExcelHandler/Models/SqlContextOut.cs

@@ -2,7 +2,6 @@ namespace BotSharp.Plugin.ExcelHandler.Models;
 
 public class SqlContextOut
 {
-    public bool isSuccessful { get; set; } 
-    public string Message { get; set; }
-    public string FileName { get; set; }
+    public bool IsSuccessful { get; set; }
+    public string Message { get; set; } = string.Empty;
 }

src/Plugins/BotSharp.Plugin.ExcelHandler/Services/MySqlService.cs

@@ -49,9 +49,8 @@ public IEnumerable<SqlContextOut> WriteExcelDataToDB(IWorkbook workbook)
             {
                 results.Add(new SqlContextOut
                 {
-                    isSuccessful = isCreateSuccess,
-                    Message = message,
-                    FileName = _currentFileName
+                    IsSuccessful = isCreateSuccess,
+                    Message = message
                 });
                 continue;
             }
@@ -64,9 +63,8 @@ public IEnumerable<SqlContextOut> WriteExcelDataToDB(IWorkbook workbook)
 
             results.Add(new SqlContextOut
             {
-                isSuccessful = isInsertSuccess,
-                Message = $"{insertMessage}\r\nExample Data: {exampleData}. \r\n The remaining data contains different values. ",
-                FileName = _currentFileName
+                IsSuccessful = isInsertSuccess,
+                Message = $"{insertMessage}\r\nExample Data: {exampleData}. \r\n The remaining data contains different values. "
             });
         }
         return results;

src/Plugins/BotSharp.Plugin.ExcelHandler/Services/SqliteService.cs

@@ -6,15 +6,12 @@ namespace BotSharp.Plugin.ExcelHandler.Services;
 public class SqliteService : IDbService
 {
     private readonly IServiceProvider _services;
-    private readonly ILogger<SqliteService> _logger;
+    private readonly ILogger _logger;
     private readonly ExcelHandlerSettings _settings;
 
-    private string _dbFilePath = string.Empty;
-    private SqliteConnection _inMemoryDbConnection = null;
     private double _excelRowSize = 0;
     private double _excelColumnSize = 0;
     private string _tableName = "tempTable";
-    private string _currentFileName = string.Empty;
     private List<string> _headerColumns = new List<string>();
     private List<string> _columnTypes = new List<string>();
 
@@ -38,24 +35,23 @@ public IEnumerable<SqlContextOut> WriteExcelDataToDB(IWorkbook workbook)
         for (int sheetIdx = 0; sheetIdx < numTables; sheetIdx++)
         {
             ISheet sheet = workbook.GetSheetAt(sheetIdx);
+
+            // create table
             var (isCreateSuccess, message) = SqlCreateTableFn(sheet);
 
-            if (!isCreateSuccess)
+            results.Add(new SqlContextOut
             {
-                results.Add(new SqlContextOut
-                {
-                    isSuccessful = isCreateSuccess,
-                    Message = message,
-                    FileName = _currentFileName
-                });
-                continue;
-            }
+                IsSuccessful = isCreateSuccess,
+                Message = message
+            });
+
+            // insert data
             var (isInsertSuccess, insertMessage) = SqlInsertDataFn(sheet);
+
             results.Add(new SqlContextOut
             {
-                isSuccessful = isInsertSuccess,
-                Message = insertMessage,
-                FileName = _currentFileName
+                IsSuccessful = isInsertSuccess,
+                Message = insertMessage
             });
         }
         return results;
@@ -69,13 +65,17 @@ public IEnumerable<SqlContextOut> WriteExcelDataToDB(IWorkbook workbook)
         {
             string dataSql = ParseSheetData(sheet);
             string insertDataSql = ProcessInsertSqlQuery(dataSql);
-            ExecuteSqlQueryForInsertion(insertDataSql);
+            var insertedRowCount = ExecuteSqlQueryForInsertion(insertDataSql);
 
-            return (true, $"{_currentFileName}: \r\n {_excelRowSize} records have been successfully inserted into `{_tableName}` table");
+            // List top 3 rows
+            var top3rows = dataSql.Split("\r").Take(3);
+            var dataSample = string.Join("\r", dataSql.Split("\r").Take(3)).Trim(',', ' ');
+
+            return (true, $"{insertedRowCount} records have been successfully inserted into `{_tableName}` table. Top {top3rows.Count()} rows:\r\n{dataSample}");
         }
         catch (Exception ex)
         {
-            return (false, $"{_currentFileName}: Failed to parse excel data into `{_tableName}` table. ####Error: {ex.Message}");
+            return (false, $"Failed to parse excel data into `{_tableName}` table. ####Error: {ex.Message}");
         }
     }
 
@@ -86,8 +86,10 @@ public IEnumerable<SqlContextOut> WriteExcelDataToDB(IWorkbook workbook)
             _tableName = sheet.SheetName;
             _headerColumns = ParseSheetColumn(sheet);
             string createTableSql = CreateDBTableSqlString(_tableName, _headerColumns, null);
-            ExecuteSqlQueryForInsertion(createTableSql);
-            return (true, $"{_tableName} has been successfully created.");
+            var rowCount = ExecuteSqlQueryForInsertion(createTableSql);
+            // Get table schema using sqlite query
+            var schema = GenerateTableSchema();
+            return (true, $"Table `{_tableName}` has been successfully created in {Provider}. Table schema:\r\n{schema}");
         }
         catch (Exception ex)
         {
@@ -166,25 +168,19 @@ private string ProcessInsertSqlQuery(string dataSql)
     {
         var wrapUpCols = _headerColumns.Select(x => $"`{x}`").ToList();
         var transferedCols = '(' + string.Join(',', wrapUpCols) + ')';
-        string insertSqlQuery = $"Insert into {_tableName} {transferedCols} Values {dataSql}";
+        string insertSqlQuery = $"INSERT INTO {_tableName} {transferedCols} VALUES {dataSql}";
         return insertSqlQuery;
     }
 
-    private void ExecuteSqlQueryForInsertion(string query)
+    private int ExecuteSqlQueryForInsertion(string query)
     {
-        var physicalDbConnection = GetPhysicalDbConnection();
-        var inMemoryDbConnection = GetInMemoryDbConnection();
+        using var conn = GetDbConnection();
 
-        physicalDbConnection.BackupDatabase(inMemoryDbConnection, "main", "main");
-        physicalDbConnection.Close();
+        using var command = new SqliteCommand();
+        command.CommandText = query;
+        command.Connection = conn;
 
-        using (var command = new SqliteCommand())
-        {
-            command.CommandText = query;
-            command.Connection = inMemoryDbConnection;
-            command.ExecuteNonQuery();
-        }
-        inMemoryDbConnection.BackupDatabase(physicalDbConnection);
+        return command.ExecuteNonQuery();
     }
 
     private void DeleteTableSqlQuery()
@@ -198,8 +194,8 @@ private void DeleteTableSqlQuery()
                     type = 'table' AND
                     name NOT LIKE 'sqlite_%'
             ";
-        var physicalDbConnection = GetPhysicalDbConnection();
-        using var selectCmd = new SqliteCommand(deleteTableSql, physicalDbConnection);
+        using var conn = GetDbConnection();
+        using var selectCmd = new SqliteCommand(deleteTableSql, conn);
         using var reader = selectCmd.ExecuteReader();
         if (reader.HasRows)
         {
@@ -212,11 +208,11 @@ name NOT LIKE 'sqlite_%'
             }
             dropTableQueries.ForEach(query =>
             {
-                using var dropTableCommand = new SqliteCommand(query, physicalDbConnection);
+                using var dropTableCommand = new SqliteCommand(query, conn);
                 dropTableCommand.ExecuteNonQuery();
             });
         }
-        physicalDbConnection.Close();
+        conn.Close();
     }
 
     private string GenerateTableSchema()
@@ -237,26 +233,30 @@ private string GenerateTableSchema()
     #endregion
 
     #region Db connection
-    private SqliteConnection GetInMemoryDbConnection()
+    private SqliteConnection GetDbConnection()
     {
-        if (_inMemoryDbConnection == null)
-        {
-            _logger.LogInformation($"Init in-memory Sqlite database connection");
-
-            _inMemoryDbConnection = new SqliteConnection("Data Source=:memory:;Mode=ReadWrite");
-            _inMemoryDbConnection.Open();
-        }
-        return _inMemoryDbConnection;
-    }
+        var connectionString = _settings.Database.ConnectionString;
+        
+        // Extract the database file path from the connection string
+        var builder = new SqliteConnectionStringBuilder(connectionString);
+        var dbFilePath = builder.DataSource;
 
-    private SqliteConnection GetPhysicalDbConnection()
-    {
-        if (string.IsNullOrEmpty(_dbFilePath))
+        _logger.LogInformation("Database file path: {DbFilePath}", dbFilePath);
+        
+        // If it's not an in-memory database, ensure the directory exists
+        if (!string.IsNullOrEmpty(dbFilePath) && 
+            !dbFilePath.Equals(":memory:", StringComparison.OrdinalIgnoreCase))
         {
-            _dbFilePath = _settings.Database.ConnectionString;
+            var directory = Path.GetDirectoryName(dbFilePath);
+            if (!string.IsNullOrEmpty(directory) && !Directory.Exists(directory))
+            {
+                Directory.CreateDirectory(directory);
+                _logger.LogInformation("Created directory: {Directory}", directory);
+            }
         }
-
-        var dbConnection = new SqliteConnection($"Data Source={_dbFilePath};Mode=ReadWrite");
+        
+        // SQLite automatically creates the database file when opening the connection
+        var dbConnection = new SqliteConnection(connectionString);
         dbConnection.Open();
         return dbConnection;
     }

src/Plugins/BotSharp.Plugin.OpenAI/Providers/Chat/ChatCompletionProvider.cs

@@ -69,6 +69,14 @@ public async Task<RoleDialogModel> GetChatCompletions(Agent agent, List<RoleDial
                 responseMessage.FunctionName = responseMessage.FunctionName.Split('.').Last();
             }
         }
+        else if (reason == ChatFinishReason.Length)
+        {
+            responseMessage = new RoleDialogModel(AgentRole.Function, $"AI response execeed max output length {options.MaxOutputTokenCount}")
+            {
+                CurrentAgentId = agent.Id,
+                MessageId = conversations.LastOrDefault()?.MessageId ?? string.Empty
+            };
+        }
         else
         {
             responseMessage = new RoleDialogModel(AgentRole.Assistant, text)

src/Plugins/BotSharp.Plugin.Planner/data/agents/282a7128-69a1-44b0-878c-a9159b88f3b9/agent.json

@@ -13,7 +13,7 @@
   "utilities": [],
   "llmConfig": {
     "provider": "openai",
-    "model": "gpt-4o-2024-11-20",
+    "model": "gpt-5-mini",
     "max_recursion_depth": 10
   }
 }

src/Plugins/BotSharp.Plugin.Planner/data/agents/3e75e818-a139-48a8-9e22-4662548c13a3/agent.json

@@ -13,7 +13,7 @@
   "utilities": [],
   "llmConfig": {
     "provider": "openai",
-    "model": "gpt-4o-2024-11-20",
+    "model": "gpt-5-mini",
     "max_recursion_depth": 10
   }
 }