Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vet and add FiniteVolumeMethod.jl #102

Open
ChrisRackauckas opened this issue Dec 8, 2022 · 3 comments
Open

Vet and add FiniteVolumeMethod.jl #102

ChrisRackauckas opened this issue Dec 8, 2022 · 3 comments

Comments

@ChrisRackauckas
Copy link
Member

It looks like it would be a good one to add: https://discourse.julialang.org/t/ann-finitevolumemethod-jl/91395. We'd need to vet it to our standards first.
@DanielVandH
Copy link
Member

Hi @ChrisRackauckas: I just came across this - is there anything in particular you're vetting for that you think might be lacking?

@ChrisRackauckas
Copy link
Member Author

The vetting is generally playing around with some examples of how it connects to the SciML verse and looking through the code a bit. I don't think you need to do much, I just need to find the time.

@DanielVandH
Copy link
Member

I see. Let me know then if anything is needed when the time comes, happy to add/improve anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @DanielVandH